Page MenuHomeFreeBSD

bhyve: Map the right BAR in init_msix_table()
ClosedPublic

Authored by markj on Jan 4 2022, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 4:36 AM
Unknown Object (File)
Tue, Feb 4, 7:22 PM
Unknown Object (File)
Tue, Feb 4, 1:31 AM
Unknown Object (File)
Sun, Feb 2, 3:04 AM
Unknown Object (File)
Jan 26 2025, 8:23 AM
Unknown Object (File)
Jan 10 2025, 10:58 AM
Unknown Object (File)
Dec 5 2024, 10:48 PM
Unknown Object (File)
Dec 2 2024, 11:50 PM
Subscribers

Details

Summary

The PBA and MSI-X table can reside in different BARs.

Reported by: Andy Fiddaman <andy@omniosce.org>
Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough")
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jan 4 2022, 7:11 PM

Fix a second bug, also reported by Andy:

If the last page containing the table is not also the last page
of the BAR, then we would call mprotect(PROT_NONE) on the wrong
portion of the mapping.

This revision is now accepted and ready to land.Jan 4 2022, 10:35 PM