Page MenuHomeFreeBSD

ipfilter Ansification: Convert K&R function declarations to ANSI
ClosedPublic

Authored by cy on Dec 20 2021, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 8:23 PM
Unknown Object (File)
Tue, Nov 12, 12:26 AM
Unknown Object (File)
Sun, Nov 10, 9:26 PM
Unknown Object (File)
Sun, Nov 10, 2:39 PM
Unknown Object (File)
Sun, Nov 10, 2:10 PM
Unknown Object (File)
Sun, Nov 10, 1:56 PM
Unknown Object (File)
Sat, Nov 9, 2:48 AM
Unknown Object (File)
Fri, Nov 8, 7:43 AM
Subscribers

Details

Summary

Convert ipfilter kernel function declarations from K&R to ANSI. This syncs our function declarations with NetBSD hg commit 75edcd7552a0 (apply our changes). Though not copied from NetBSD, this change was partially inspired by NetBSD's work and inspired by style(9).

Test Plan

Currently running here.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cy requested review of this revision.Dec 20 2021, 10:37 PM

The uppercase INLINE, which I guess is a macro, can be substituted to lowercase inline, which is part of modern C in the same sweep.

P.S. IMHO such mechanical sweeps don't deserve a publication of review and don't require reviewers.

This revision is now accepted and ready to land.Dec 21 2021, 3:51 PM

Thanks. INLINE --> inline should be a separate pair of commits.

Also planned is conform "return" statements to style(9).

This revision was automatically updated to reflect the committed changes.