Page MenuHomeFreeBSD

Convert bsdinstall/partedit sade(8) for libbsddialog
AbandonedPublic

Authored by asiciliano on Dec 16 2021, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 12:16 PM
Unknown Object (File)
Sat, Apr 27, 12:16 PM
Unknown Object (File)
Sat, Apr 27, 12:16 PM
Unknown Object (File)
Sat, Apr 27, 10:48 AM
Unknown Object (File)
Dec 23 2023, 12:46 AM
Unknown Object (File)
Dec 11 2023, 2:47 AM
Unknown Object (File)
Aug 19 2023, 8:46 PM
Unknown Object (File)
Mar 5 2023, 7:59 AM
Subscribers

Details

Summary

First try for bsdinstall/partedit sade(8) with libbsddialog.

I am considering a call for testing, hackers@? (Test Plan below).

This review depends on libbsddialog 0.0.2 https://reviews.freebsd.org/D33580

Test Plan

Menu, checkelist, msgbox , yesno and infobox tested via tzsetup, kbdmap and portconfig.

We need to test forms (this is the first real world use/test case).
"Isolation" test with debug symbols:

% git clone https://gitlab.com/alfix/bsddialog.git
% cd bsddialog/
% git clone https://gitlab.com/alfix/freebsd-lab.git
% cd freebsd-lab/bsdinstall/partedit/
% make -DDEBUG
% ./sade

To check:

  • Forms: <Create> and <Modify>
  • ZFS

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

asiciliano edited the test plan for this revision. (Show Details)
asiciliano added a reviewer: allanjude.
asiciliano edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Dec 21 2021, 3:16 PM

Update diff:

  • fix: style(9) withespace and comment
  • delete: useless constant (diskmenu.h)
  • fix: focus on the last selected item after a diskmenu refresh (like diskeditor)
This revision now requires review to proceed.Dec 29 2021, 10:23 PM

Abandon Review: a complete libbsddialog version is almost ready, I' ll update a new snapshot and a revision for sade soon.