Page MenuHomeFreeBSD

loader: Add a readtest command
ClosedPublic

Authored by manu on Dec 13 2021, 10:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 4:47 AM
Unknown Object (File)
Thu, May 9, 4:47 AM
Unknown Object (File)
Thu, May 9, 4:47 AM
Unknown Object (File)
Thu, May 9, 4:47 AM
Unknown Object (File)
Wed, May 8, 3:58 PM
Unknown Object (File)
Mar 7 2024, 7:52 PM
Unknown Object (File)
Feb 14 2024, 11:59 AM
Unknown Object (File)
Jan 17 2024, 2:44 AM

Details

Summary

readtest will simply load the file in memory, useful for timing
loading on some filesystems.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu requested review of this revision.Dec 13 2021, 10:50 AM

I think, this should be generic command - it would do for any filesystem read.

I think, this should be generic command - it would do for any filesystem read.

Sure, like "read" ?

In D33411#755311, @manu wrote:

I think, this should be generic command - it would do for any filesystem read.

Sure, like "read" ?

perhaps readtest or something, plain read may be confusing.

stand/libsa/tftp.c
776

Since BIOS loader stack may be very limited (due to memory setup we do have), I'd rather use dynamic allocation there.

imp added inline comments.
stand/libsa/tftp.c
786

So what's the format of 'filename' here?

Rename the command to readtest

manu retitled this revision from loader: tftp: Add a tftp command to loader: Add a readtest command.Dec 15 2021, 10:15 AM
manu edited the summary of this revision. (Show Details)
manu added inline comments.
stand/libsa/tftp.c
786

Simply a path.

This revision is now accepted and ready to land.Dec 15 2021, 5:21 PM
This revision was automatically updated to reflect the committed changes.