loader: tftp: Don't error on tftp error 0
ClosedPublic
Actions

Authored by manu on Dec 13 2021, 10:45 AM.

Details

Reviewers

imp
tsoome

Group Reviewers

Loader

Commits

rG62c7a7774fc7: loader: tftp: Don't error on tftp error 0
rGbf07f2f8623d: loader: tftp: Don't error on tftp error 0

Summary

tftp-hpa sends NAK with tftp error set to 0 when trying to get
a directory and this is the first thing that loader tries to do
and this make it hangs.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43307
Build 40195: arc lint + arc unit

Event Timeline

manu created this revision.Dec 13 2021, 10:45 AM

Herald added subscribers: Contributor Reviews (src), dab, imp. · View Herald TranscriptDec 13 2021, 10:45 AM

manu requested review of this revision.Dec 13 2021, 10:45 AM

Harbormaster completed remote builds in B43307: Diff 99912.Dec 13 2021, 10:45 AM

manu added a reviewer: Loader.Dec 13 2021, 10:50 AM

emaste added a subscriber: emaste.Dec 13 2021, 1:44 PM

imp added inline comments.Dec 13 2021, 4:21 PM

stand/libsa/tftp.c
249	So what happens if we get a NAK during a normal transfer of a file?

manu added inline comments.Dec 14 2021, 8:43 AM

stand/libsa/tftp.c
249	I don't think it can happens tbh ...

imp accepted this revision.Dec 14 2021, 5:34 PM

imp added inline comments.

stand/libsa/tftp.c
249	OK Just wondering the blast radius of this change outside of the problem you're trying to fix. If we don't have something specific, then I'm no objection.

This revision is now accepted and ready to land.Dec 14 2021, 5:34 PM