Page MenuHomeFreeBSD

loader: tftp: Don't error on tftp error 0
ClosedPublic

Authored by manu on Dec 13 2021, 10:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 29, 10:54 AM
Unknown Object (File)
May 11 2024, 9:03 PM
Unknown Object (File)
May 9 2024, 2:52 PM
Unknown Object (File)
May 9 2024, 2:51 PM
Unknown Object (File)
May 9 2024, 11:04 AM
Unknown Object (File)
May 9 2024, 4:48 AM
Unknown Object (File)
Mar 7 2024, 6:08 PM
Unknown Object (File)
Feb 22 2024, 6:29 AM

Details

Summary

tftp-hpa sends NAK with tftp error set to 0 when trying to get
a directory and this is the first thing that loader tries to do
and this make it hangs.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu requested review of this revision.Dec 13 2021, 10:45 AM
stand/libsa/tftp.c
249

So what happens if we get a NAK during a normal transfer of a file?

stand/libsa/tftp.c
249

I don't think it can happens tbh ...

imp added inline comments.
stand/libsa/tftp.c
249

OK Just wondering the blast radius of this change outside of the problem you're trying to fix. If we don't have something specific, then I'm no objection.

This revision is now accepted and ready to land.Dec 14 2021, 5:34 PM
tsoome added a subscriber: tsoome.

I haven't seen any wrong happening from it either.

This revision was automatically updated to reflect the committed changes.