sysent: add sysent-force targets
ClosedPublic
Actions

Authored by kevans on Dec 9 2021, 5:23 AM.

Details

Reviewers

kib
brooks
jrtc27

Commits

rG8ea3921f932c: sysent: regenerate files every time

Summary

This forces everything to be regenerated by marking makesyscalls.lua
as .PHONY, which may be helpful in, e.g., rebase scenarios.

Requested by: kib

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Dec 9 2021, 5:23 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptDec 9 2021, 5:23 AM

kevans requested review of this revision.Dec 9 2021, 5:23 AM

Harbormaster completed remote builds in B43257: Diff 99760.Dec 9 2021, 5:23 AM

Thank you very much.

This revision is now accepted and ready to land.Dec 9 2021, 5:30 AM

Is sysent ever invoked as a dependency of some other part of the build? Could we just make make sysent always build?

Right now it's never a dependency. In some ways it would be nice if it was and we could stop committing generated files, but it's potential confusing if we don't have syscalls.h and sysproto.h in the tree.

brooks accepted this revision.Dec 10 2021, 6:50 PM

Sorry, just getting back after being away for a few days. I don't actually have a strong preference for sysent-force vs. just having sysent always regenerate. On my less-than-stellar laptop, make -j4 sysent is a hair over half a second; given how infrequently this happens in the best case, that seems minimal enough to punt until someone complains.