LinuxKPI: Implement default sysfs kobject attribute operations
ClosedPublic
Actions

Authored by wulf on Dec 6 2021, 9:59 AM.

Details

Reviewers

• hselasky
manu

Commits

rG9e736b8b8a1e: LinuxKPI: Implement default sysfs kobject attribute operations
rG04d42cb45388: LinuxKPI: Implement default sysfs kobject attribute operations

Summary

Required by drm-kmod 5.7

MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43177
Build 40065: arc lint + arc unit

Event Timeline

wulf created this revision.Dec 6 2021, 9:59 AM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptDec 6 2021, 9:59 AM

wulf requested review of this revision.Dec 6 2021, 9:59 AM

Harbormaster completed remote builds in B43177: Diff 99525.Dec 6 2021, 9:59 AM

• hselasky added inline comments.Dec 6 2021, 10:11 AM

sys/compat/linuxkpi/common/include/linux/kobject.h
71	Should this definition be moved to: sys/compat/linuxkpi/common/include/linux/sysfs.h

wulf added inline comments.Dec 6 2021, 10:28 AM

sys/compat/linuxkpi/common/include/linux/kobject.h
71	That is where it is defined in Linux: https://elixir.bootlin.com/linux/v5.16-rc4/source/include/linux/kobject.h#L170

• hselasky added inline comments.Dec 6 2021, 10:53 AM

sys/compat/linuxkpi/common/include/linux/kobject.h
71	OK, I think you need to add: struct sysfs_ops; At the beginning of this file to avoid issues with standalone inclusion.

wulf added inline comments.Dec 6 2021, 11:19 AM

sys/compat/linuxkpi/common/include/linux/kobject.h
71	It looks unnecessary. I just placed extern struct foo bar; line in to this file and it still compiles

OK, try -Wall just in case.

This revision is now accepted and ready to land.Dec 6 2021, 11:30 AM

Closed by commit rG04d42cb45388: LinuxKPI: Implement default sysfs kobject attribute operations (authored by wulf). · Explain WhyJan 10 2022, 7:51 PM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG04d42cb45388: LinuxKPI: Implement default sysfs kobject attribute operations.

wulf added a commit: rG9e736b8b8a1e: LinuxKPI: Implement default sysfs kobject attribute operations.Jan 22 2022, 7:39 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

kobject.h

2 lines

src/

linux_compat.c

30 lines

Diff 99525

View Options

sys/compat/linuxkpi/common/include/linux/kobject.h