Page MenuHomeFreeBSD
Differential D3320

Make some geom_uncompress debug printf's into DPRINTF's to reduce noise on attach/detach
ClosedPublic
Actions

Authored by ngie on Aug 6 2015, 3:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 4, 2:30 AM
Unknown Object (File)
Tue, Sep 29, 4:10 PM
Unknown Object (File)
Tue, Sep 29, 2:34 PM
Unknown Object (File)
Sat, Sep 26, 10:31 PM
Unknown Object (File)
Wed, Sep 23, 8:55 PM
Unknown Object (File)
Mon, Sep 14, 2:40 AM
Unknown Object (File)
Mon, Sep 14, 2:34 AM
Unknown Object (File)
Thu, Sep 10, 12:58 AM
View All Files
Subscribers
imp
markj
ray
sobomax

Details

Reviewers
loos
Summary

Make some geom_uncompress debug printf's into DPRINTF's to reduce noise on attach/detach

Similar reasoning to what was done in r286367 with geom_uzip(4)

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

ngie updated this revision to Diff 7719.Aug 6 2015, 3:38 PM
ngie retitled this revision from to Make some geom_uncompress debug printf's into DPRINTF's to reduce noise on attach/detach.
ngie updated this object.
ngie added a reviewer: loos.
ngie added a subscriber: markj.
Herald added a subscriber: imp. · View Herald TranscriptAug 6 2015, 3:38 PM
loos accepted this revision.Aug 7 2015, 10:32 PM
loos edited edge metadata.

Thanks for the quick response Garret!

Looks good to me.

This revision is now accepted and ready to land.Aug 7 2015, 10:32 PM
ngie mentioned this in rS286512: Make some debug printf's into DPRINTF's to reduce noise on attach/detahh.Aug 9 2015, 6:58 AM
ngie closed this revision.Aug 9 2015, 6:59 AM
In D3320#67701, @loos wrote:

Thanks for the quick response Garret!

Looks good to me.

Np :)! Thanks for the quick review!

ngie mentioned this in rS289958: MFC r286512:.Oct 25 2015, 10:38 PM
sobomax added subscribers: ray, sobomax.Feb 18 2016, 11:47 PM

For what's worth, I think those two should be merged into one entity, not carried forward in parallel. I don't know why the g_uncompress/mkulzma has been added in the first place if it provides a superset of g_uzip / mkuzip's functionality and should have been just the new code / CLI option for the latter. I don't know if @ray is available for the comment and svn logs provide no clue, but I see no reason for such code bloat.

I just did lot of work on improving both g_uzip / mkuzip and I did not even realize we have its almost complete twins in the tree. :(

Revision Contents
Changeset List

PathSize
sys/
geom/
uncompress/
12 lines

Diff 7719

View Options

sys/geom/uncompress/g_uncompress.c

Loading...