Page MenuHomeFreeBSD

devel/py-jsonpath-ng: New port
ClosedPublic

Authored by driesm on Nov 26 2021, 6:30 PM.

Details

Summary
devel/py-jsonpath-ng: New port

JSONPath implementation based on jsonpath-rw and jsonpath-rw-ext

 PR:		258149
 Approved by:	tbd (mentor)
 Differential Revision: https://reviews.freebsd.org/D33135
Test Plan

Poudriere testport looks good.
Portlint, portclippy, portfmt all happy.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

driesm edited the test plan for this revision. (Show Details)
driesm edited the test plan for this revision. (Show Details)
driesm added reviewers: 0mp, philip.
0mp requested changes to this revision.Nov 26 2021, 6:44 PM
0mp added inline comments.
devel/py-jsonpath-ng/Makefile
8

How about something like this? A COMMENT beginning with "this" does not sound good.

Note: python packages should ideally use the description from pypi: https://pypi.org/project/jsonpath-ng/

"A final implementation of JSONPath for Python that aims to be standard compliant, including arithmetic and binary comparison operators and providing clear AST for metaprogramming." is slightly too long so the right way to do it is to shorten it as much as possible.

10

note: if the project distributes a license file, it is a good idea to set LICENSE_FILE.

This revision now requires changes to proceed.Nov 26 2021, 6:44 PM

Use much nicer pkg COMMENT.

driesm added inline comments.
devel/py-jsonpath-ng/Makefile
8

I like it! Done.

10

The PyPi distfile doesn't include a LICENSE file.

driesm marked 2 inline comments as done.
This revision is now accepted and ready to land.Nov 27 2021, 3:44 PM
This revision was automatically updated to reflect the committed changes.