Page MenuHomeFreeBSD
Differential D33071

arm64: Enable SHA256 instruction in the kernel
Needs ReviewPublic
Actions

Authored by allanjude on Nov 21 2021, 4:46 PM.
Tags
None
Referenced Files
F171647553: D33071.id98799.diff
Sat, Sep 12, 10:27 AM
Unknown Object (File)
Tue, Sep 8, 10:04 AM
Unknown Object (File)
Tue, Sep 8, 10:00 AM
Unknown Object (File)
Mon, Sep 7, 7:12 AM
Unknown Object (File)
Mon, Sep 7, 4:07 AM
Unknown Object (File)
Sun, Sep 6, 11:53 PM
Unknown Object (File)
Sun, Sep 6, 1:45 PM
Unknown Object (File)
Sun, Sep 6, 9:40 AM
View All Files
Subscribers
imp
jmg

Details

Reviewers
andrew
emaste
mhorne
Summary

This enables the existing support for ARM64 SHA2 instructions in
userland (used by libmd) to be used in the kernel and various modules
like: crypto, ipsec, geli, zfs

Sponsored by: Ampere Computing LLC
Sponsored by: Klara Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42908
Build 39796: arc lint + arc unit

Event Timeline

allanjude created this revision.Nov 21 2021, 4:46 PM
Herald added subscribers: jmg, imp. · View Herald TranscriptNov 21 2021, 4:46 PM
allanjude requested review of this revision.Nov 21 2021, 4:46 PM
Harbormaster completed remote builds in B42907: Diff 98799.Nov 21 2021, 4:46 PM
andrew added a comment.Nov 21 2021, 5:20 PM

Is this safe if the caller doesn't have a floating point context? It could trash userspace floating point registers.

sys/conf/files.arm64
147

We also need -DARM64_SHA2 on sha256c.c. It might be easiest to add via CFLAGS.sha256c.c+=... in Makefile.arm64 and the module Makefile.

allanjude updated this revision to Diff 98802.Nov 21 2021, 5:38 PM

Update to fix build error

Harbormaster completed remote builds in B42908: Diff 98802.Nov 21 2021, 5:38 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
7 lines
crypto/
sha2/
21 lines
modules/
crypto/
10 lines

Diff 98802

View Options

sys/conf/files.arm64

Loading...
View Options

sys/crypto/sha2/sha256c.c

Loading...
View Options

sys/modules/crypto/Makefile

Loading...