Fix dtrace SDT probe tcp:::debug-input
ClosedPublic
Actions

Authored by rew on Nov 20 2021, 5:13 AM.

Tags

None

Referenced Files

	F135954544: D33066.id98771.diff
	Fri, Nov 14, 12:58 PM

	F135954541: D33066.id100386.diff
	Fri, Nov 14, 12:58 PM

	F135954440: D33066.diff
	Fri, Nov 14, 12:57 PM

	Unknown Object (File)
	Mon, Nov 10, 2:05 PM

	Unknown Object (File)
	Thu, Nov 6, 3:25 PM

	Unknown Object (File)
	Tue, Nov 4, 7:35 PM

	Unknown Object (File)
	Tue, Nov 4, 1:53 PM

	Unknown Object (File)
	Tue, Nov 4, 11:06 AM

Subscribers

Details

Reviewers

gnn
markj

Commits

rGbcc9518b98b3: Fix dtrace SDT probe tcp:::debug-input
rG08d157a8321c: Fix dtrace SDT probe tcp:::debug-input

Summary

The tcp:::debug-input expects an mbuf pointer.

I think this was missed in 82988b50a17ccd6a39d9bb49f15f42b11fc6a052.

With this patch, the tcp:::debug-input probe prints the correct
ip addresses, version, and packet length.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rew created this revision.Nov 20 2021, 5:13 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptNov 20 2021, 5:13 AM

rew requested review of this revision.Nov 20 2021, 5:13 AM

Harbormaster completed remote builds in B42900: Diff 98771.Nov 20 2021, 5:13 AM

rew added reviewers: gnn, markj.Nov 20 2021, 5:15 AM

markj accepted this revision.Nov 20 2021, 2:07 PM

This revision is now accepted and ready to land.Nov 20 2021, 2:07 PM

Closed by commit rG08d157a8321c: Fix dtrace SDT probe tcp:::debug-input (authored by rew). · Explain WhyDec 21 2021, 2:19 AM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rG08d157a8321c: Fix dtrace SDT probe tcp:::debug-input.

rew added a commit: rGbcc9518b98b3: Fix dtrace SDT probe tcp:::debug-input.Feb 23 2022, 5:49 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_kdtrace.c

2 lines

Diff 100386

View Options

Fix dtrace SDT probe tcp:::debug-inputClosedPublicActions