Page MenuHomeFreeBSD
Differential D33024

tcp_hpts: make struct tcp_hpts_entry private to the module.
ClosedPublic
Actions

Authored by glebius on Nov 16 2021, 9:39 PM.

Details

Reviewers
rrs
Group Reviewers
transport
Commits
R10:b0a7c008cbc6: tcp_hpts: make struct tcp_hpts_entry private to the module.
Summary

Also, make some of the functions also private to the module. Remove
unused functions discovered after that.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

glebius created this revision.Nov 16 2021, 9:39 PM
Herald added a reviewer: transport. · View Herald TranscriptNov 16 2021, 9:39 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
glebius requested review of this revision.Nov 16 2021, 9:39 PM
glebius added a parent revision: D33023: tcp_hpts: provide tcp_in_hpts()..
Harbormaster completed remote builds in B42824: Diff 98613.Nov 16 2021, 9:39 PM
glebius added a child revision: D33025: tcp_hpts: rename input queue to drop queue and trim dead code.Nov 16 2021, 9:39 PM
rrs accepted this revision.Nov 17 2021, 7:25 PM
rrs added a subscriber: rrs.

I am usually not a big fan of this type of actions. I like
structures to be in a header file instead of buried in the
.c file.. but if you really think its a good idea.. i guess its ok.. my
feelings are not that strong about it.

This revision is now accepted and ready to land.Nov 17 2021, 7:25 PM
glebius updated this revision to Diff 98729.Nov 19 2021, 4:39 AM

Rebased on newer main.

This revision now requires review to proceed.Nov 19 2021, 4:39 AM
Harbormaster completed remote builds in B42882: Diff 98729.Nov 19 2021, 4:39 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 2 2021, 6:52 PM
Closed by commit R10:b0a7c008cbc6: tcp_hpts: make struct tcp_hpts_entry private to the module. (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: R10:b0a7c008cbc6: tcp_hpts: make struct tcp_hpts_entry private to the module..

Revision Contents
Changeset List

PathSize
sys/
netinet/
105 lines
151 lines

Diff 99368

View Options

sys/netinet/tcp_hpts.h

Loading...
View Options

sys/netinet/tcp_hpts.c

Loading...