Page MenuHomeFreeBSD
Differential D32981

ktls: Add tests ensuring invalid receive cipher suites are rejected.
ClosedPublic
Actions

Authored by jhb on Nov 13 2021, 12:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 4:15 PM
Unknown Object (File)
Fri, Sep 11, 6:22 AM
Unknown Object (File)
Wed, Sep 9, 6:39 PM
Unknown Object (File)
Wed, Sep 9, 12:03 AM
Unknown Object (File)
Sun, Sep 6, 7:34 PM
Unknown Object (File)
Sun, Sep 6, 8:32 AM
Unknown Object (File)
Sat, Sep 5, 1:50 AM
Unknown Object (File)
Fri, Sep 4, 8:44 PM
View All Files
Subscribers
gallatin
imp

Details

Reviewers
markj
Commits
rGe91446cd84b3: ktls: Add tests ensuring invalid receive cipher suites are rejected.
rG233ce578a424: ktls: Add tests ensuring invalid receive cipher suites are rejected.
Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Nov 13 2021, 12:09 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 13 2021, 12:09 AM
jhb requested review of this revision.Nov 13 2021, 12:09 AM
jhb added a parent revision: D32980: ktls: Add simple receive tests of kernel TLS..
jhb added a child revision: D32982: ktls: Add tests ensuring unsupported receive cipher suites are rejected..
Harbormaster completed remote builds in B42774: Diff 98460.Nov 13 2021, 12:09 AM
markj accepted this revision.Nov 15 2021, 3:10 PM
markj added inline comments.
tests/sys/kern/ktls_test.c
1587

I should have pointed this out in earlier reviews, sorry, but I think it'd be good to validate the return value from close() for socket pairs.

This revision is now accepted and ready to land.Nov 15 2021, 3:10 PM
jhb added inline comments.Nov 15 2021, 7:31 PM
tests/sys/kern/ktls_test.c
1587

Hmm, I can perhaps do that as a followup change.

Closed by commit rG233ce578a424: ktls: Add tests ensuring invalid receive cipher suites are rejected. (authored by jhb). · Explain WhyNov 15 2021, 8:04 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG233ce578a424: ktls: Add tests ensuring invalid receive cipher suites are rejected..
jhb added a commit: rGe91446cd84b3: ktls: Add tests ensuring invalid receive cipher suites are rejected..Nov 23 2021, 11:14 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
47 lines

Diff 98534

View Options

tests/sys/kern/ktls_test.c

Loading...