ktls: Add padding tests for AES-CBC MTE cipher suites.
ClosedPublic
Actions

Authored by jhb on Nov 5 2021, 12:00 AM.

Details

Reviewers

Commits

rG9b6f4b35d2c2: ktls: Add padding tests for AES-CBC MTE cipher suites.
rG44265dc3dae1: ktls: Add padding tests for AES-CBC MTE cipher suites.

Summary

For each AES-CBC MTE cipher suite, test sending records with 1 to 16
bytes of payload. This ensures that all of the potential padding
values are covered.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 5 2021, 12:00 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 5 2021, 12:00 AM

jhb requested review of this revision.Nov 5 2021, 12:00 AM

Harbormaster completed remote builds in B42590: Diff 98038.Nov 5 2021, 12:00 AM

jhb added a child revision: D32841: ktls: Add tests for sending empty fragments for TLS 1.0 connections..Nov 5 2021, 12:03 AM

markj accepted this revision.Nov 13 2021, 2:35 AM

markj added inline comments.

tests/sys/kern/ktls_test.c
1104	Does it make sense to test a message of length 0? I'm not sure if empty records are permitted (though ISTR they are used in TLS 1.0).

This revision is now accepted and ready to land.Nov 13 2021, 2:35 AM

jhb marked an inline comment as done.Nov 15 2021, 7:20 PM

jhb added inline comments.

tests/sys/kern/ktls_test.c
1104	I did that in a followup set of tests for TLS 1.0. :)

Closed by commit rG44265dc3dae1: ktls: Add padding tests for AES-CBC MTE cipher suites. (authored by jhb). · Explain WhyNov 15 2021, 8:03 PM

This revision was automatically updated to reflect the committed changes.

jhb marked an inline comment as done.

jhb added a commit: rG44265dc3dae1: ktls: Add padding tests for AES-CBC MTE cipher suites..

jhb added a commit: rG9b6f4b35d2c2: ktls: Add padding tests for AES-CBC MTE cipher suites..Nov 23 2021, 11:14 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

ktls_test.c

95 lines

Diff 98529

View Options

tests/sys/kern/ktls_test.c

ktls: Add padding tests for AES-CBC MTE cipher suites.ClosedPublicActions