Paths

Table of Contentst

Differential D3257

ThunderX external PCIe driver
ClosedPublic
Actions

Authored by wma_semihalf.com on Jul 31 2015, 5:55 AM.

Tags

None

Referenced Files

	F110743286: D3257.diff
	Sat, Feb 22, 1:49 PM

	Unknown Object (File)
	Fri, Feb 7, 7:10 PM

	Unknown Object (File)
	Tue, Jan 28, 2:22 AM

	Unknown Object (File)
	Fri, Jan 24, 12:38 AM

	Unknown Object (File)
	Jan 18 2025, 7:04 AM

	Unknown Object (File)
	Jan 18 2025, 2:32 AM

	Unknown Object (File)
	Jan 18 2025, 12:26 AM

	Unknown Object (File)
	Jan 7 2025, 1:02 PM

Subscribers

Details

Reviewers

zbb
emaste
jhb
andrew

Commits

rS286477: Add support for external PCIe (PEM) on Cavium's ThunderX

Summary

Support for external PCIe (PEM)

Dependent on:
https://reviews.freebsd.org/D3031

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wma_semihalf.com updated this revision to Diff 7539.Jul 31 2015, 5:55 AM

wma_semihalf.com retitled this revision from to ThunderX external PCIe driver.

wma_semihalf.com updated this object.

wma_semihalf.com edited the test plan for this revision. (Show Details)

wma_semihalf.com added reviewers: jhb, zbb, andrew, emaste.

wma_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJul 31 2015, 5:55 AM

wma_semihalf.com added a parent revision: D3031: PCIe support for ThunderX.Jul 31 2015, 5:58 AM

wma_semihalf.com added inline comments.Jul 31 2015, 7:07 PM

sys/arm64/cavium/thunder_pcie_pem.c
501	Ooops... will add SYS_RES_IO here.

Applying fixes from internal PCIe review here also.

One general comment that I missed in the earlier review is that you will need to have a bus_adjust_resource() method eventually to support NEW_PCIB. That is not a hard requirement since other parts of arm are behind on this. Aside from that this looks fine.

Thanks, good point!
The next step for this driver is to enhance resource allocation in case the size is unknown (line #442) which is required for ThunderX ethernet NIC we're currently developing the driver for.
If you don't mind, I'd like to commit this file as-is and add support for NEW_PCIB later, along with previously mentioned VFs. I think I should make this in a week or two.

jhb accepted this revision.Aug 6 2015, 10:26 AM

jhb edited edge metadata.

This revision is now accepted and ready to land.Aug 6 2015, 10:26 AM

andrew added inline comments.Aug 6 2015, 10:40 AM

sys/arm64/cavium/thunder_pcie_pem.c
512	This should be a `BUS_PROBE_` value.

Closed by commit rS286477: Add support for external PCIe (PEM) on Cavium's ThunderX (authored by zbb). · Explain WhyAug 8 2015, 9:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

cavium/

thunder_pcie_pem.c

634 lines

conf/

1 line

Diff 7596

sys/arm64/cavium/thunder_pcie_pem.c

Loading...

sys/conf/files.arm64

Loading...