Only change the fadt revision in acpidump on i386
ClosedPublic
Actions

Authored by andrew on Oct 20 2021, 9:38 AM.

Details

Reviewers

dch
emaste
jkim
jhb

Commits

rGefa206137718: Only change the fadt revision in acpidump on i386
rG01593a0ff9f1: Only change the fadt revision in acpidump on i386

Summary

There is a workaround in acpidump for an old IBM laptop. This is being
hit on a modern arm64 system causing acpidump to use the wrong field
when reading a later address.

As the laptop has a 32-bit CPU the only FreeBSD support for it is i386.
As such limit the workaround to that architecture.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Oct 20 2021, 9:38 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2021, 9:38 AM

andrew requested review of this revision.Oct 20 2021, 9:38 AM

Harbormaster completed remote builds in B42267: Diff 97160.Oct 20 2021, 9:38 AM

emaste accepted this revision.Oct 20 2021, 12:35 PM

This revision is now accepted and ready to land.Oct 20 2021, 12:35 PM

Even though the issue may apply to more than just that one type of laptop I imagine all instances will involve early 32-bit ACPI implementations. So __i386__ is appropriate.

LGTM. In fact, this bug should not exist in any modern systems.

jkim accepted this revision.Oct 20 2021, 3:55 PM

jhb accepted this revision.Oct 20 2021, 4:03 PM

jhb added inline comments.

usr.sbin/acpi/acpidump/acpi.c
223	Minor nit, I would put the comment under #ifdef as well.

emaste added inline comments.Oct 20 2021, 4:32 PM

usr.sbin/acpi/acpidump/acpi.c
223	I was thinking the same thing but thought it was too minor even for a comment :) Since I'm now commenting, perhaps also extend the comment to mention that only very early ACPI implementations are expected to be affected and the workaround breaks newer systems, so apply only to 32-bit x86.