loader bcache: Refactor adjustment of ra

[cperciva]

Summary

This will make future changes cleaner. No functional change intended.

[tsoome]

It does feel wrong to have two if (complete) blocks in a row, perhaps it isworth to factor ra update out to separate function at some time...

[cperciva]

In D32249#727706, @tsoome wrote:

It does feel wrong to have two if (complete) blocks in a row, perhaps it isworth to factor ra update out to separate function at some time...

I considered that, but since this is the only place we adjust bc->ra it seemed like an unnecessary complication to add a new function; at least now the changes are collected together in one place.

The entire function could probably do with being refactored and/or restyled, but that seemed like something which could wait.

[tsoome]

In D32249#728568, @cperciva wrote:

In D32249#727706, @tsoome wrote:

It does feel wrong to have two if (complete) blocks in a row, perhaps it isworth to factor ra update out to separate function at some time...

I considered that, but since this is the only place we adjust bc->ra it seemed like an unnecessary complication to add a new function; at least now the changes are collected together in one place.

The entire function could probably do with being refactored and/or restyled, but that seemed like something which could wait.

ack.