Page MenuHomeFreeBSD

loader bcache: Refactor adjustment of ra
ClosedPublic

Authored by cperciva on Oct 1 2021, 4:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 5:48 PM
Unknown Object (File)
Feb 18 2024, 7:34 AM
Unknown Object (File)
Dec 20 2023, 7:34 PM
Unknown Object (File)
Oct 12 2023, 9:40 AM
Unknown Object (File)
Sep 25 2023, 9:45 AM
Unknown Object (File)
Sep 6 2023, 2:37 PM
Unknown Object (File)
Jul 11 2023, 2:05 PM
Unknown Object (File)
Jun 8 2023, 10:05 PM
Subscribers

Details

Summary

This will make future changes cleaner. No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It does feel wrong to have two if (complete) blocks in a row, perhaps it isworth to factor ra update out to separate function at some time...

This revision is now accepted and ready to land.Oct 1 2021, 7:21 AM

It does feel wrong to have two if (complete) blocks in a row, perhaps it isworth to factor ra update out to separate function at some time...

I considered that, but since this is the only place we adjust bc->ra it seemed like an unnecessary complication to add a new function; at least now the changes are collected together in one place.

The entire function could probably do with being refactored and/or restyled, but that seemed like something which could wait.

It does feel wrong to have two if (complete) blocks in a row, perhaps it isworth to factor ra update out to separate function at some time...

I considered that, but since this is the only place we adjust bc->ra it seemed like an unnecessary complication to add a new function; at least now the changes are collected together in one place.

The entire function could probably do with being refactored and/or restyled, but that seemed like something which could wait.

ack.