Differential D32140

devel/ruby-build: Update to 20210925
ClosedPublic
Actions

Authored by meta on Sep 25 2021, 2:45 PM.

Details

Reviewers

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

meta created this revision.Sep 25 2021, 2:45 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptSep 25 2021, 2:45 PM

meta requested review of this revision.Sep 25 2021, 2:45 PM

Harbormaster completed remote builds in B41759: Diff 95724.Sep 25 2021, 2:45 PM

This is a test how to use phabricator with git.

The change looks fine by me, but you didn't specify any reviewers. Who do you want to get an OK from?

koobs added a reviewer: Contributor Reviewers (ports).Sep 25 2021, 10:53 PM

@meta

Is the current SUMMARY the complete proposed commit log message?
Is this a bugfix release? Will it be MFH'd?

MFH: <branch>|No> (<reason>)

Do the changes pass QA (poudriere?) Please add to TEST PLAN:

portlint: OK (looks fine.)
testport: OK (poudriere: <which archs/versions/OPTIONS were tested)

In D32140#725325, @arrowd wrote:

The change looks fine by me, but you didn't specify any reviewers. Who do you want to get an OK from?

I just wanted to learn using Phabricator with git because I never used it after we switched to git from svn. Not for getting actual review. I’m mentoring a new committer so I want to teach him how to use Phabricator.

So no reviewers are fine. Please leave it. Sorry for the noise.

This is a practice to learn how to use Phabricator with git ports tree. I'm mentoring a new committer and would like to use Phabricator in mentor-mentee review. So approving this by myself.

This revision is now accepted and ready to land.Sep 27 2021, 6:42 AM

Update commit message.

This revision now requires review to proceed.Sep 27 2021, 6:46 AM

Harbormaster completed remote builds in B41776: Diff 95765.Sep 27 2021, 6:47 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 27 2021, 6:52 AM

Closed by commit R11:22b087cde88d: devel/ruby-build: Update to 20210925 (authored by meta). · Explain Why

This revision was automatically updated to reflect the committed changes.

meta added a commit: R11:22b087cde88d: devel/ruby-build: Update to 20210925.

yasu added a commit: R11:8a42d3d971b5: devel/ruby-build: Update to 20210925.Sep 28 2021, 5:59 AM