Differential D31968

Remove PT_GET_SC_ARGS_ALL
ClosedPublic
Actions

Authored by kib on Sep 15 2021, 1:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 6:32 PM

	Unknown Object (File)
	Fri, May 3, 2:28 AM

	Unknown Object (File)
	Tue, Apr 30, 3:57 PM

	Unknown Object (File)
	Mar 30 2024, 7:03 AM

	Unknown Object (File)
	Mar 28 2024, 7:02 AM

	Unknown Object (File)
	Mar 24 2024, 8:28 PM

	Unknown Object (File)
	Mar 22 2024, 5:36 PM

	Unknown Object (File)
	Mar 22 2024, 5:36 PM

View All 51 Files

Subscribers

Details

Reviewers

jhb
trasz

Commits

rG4cae9d803a95: Remove PT_GET_SC_ARGS_ALL
rGf575573ca577: Remove PT_GET_SC_ARGS_ALL

Summary

Reimplement bdf0f24bb16d556a5b by checking for the caller' ABI in the implementation of PT_GET_SC_ARGS, and copying out everything if it is Linuxolator.

Also fix a minor information leak: if PT_GET_SC_ARGS_ALL is done on the thread reused after other process, it allows to read some number of that thread last syscall arguments. Clear td_sa.args in thread_alloc().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sep 15 2021, 1:29 PM

Herald added a subscriber: emaste. · View Herald TranscriptSep 15 2021, 1:29 PM

kib requested review of this revision.Sep 15 2021, 1:29 PM

jhb accepted this revision.Sep 15 2021, 5:25 PM

jhb added inline comments.

sys/amd64/linux/linux_ptrace.c
547–554

This revision is now accepted and ready to land.Sep 15 2021, 5:25 PM

rew added a subscriber: rew.Sep 15 2021, 6:43 PM

rew added inline comments.

sys/amd64/linux/linux_ptrace.c
559

Update comment.

This revision now requires review to proceed.Sep 15 2021, 7:14 PM

Correct the right place.

jhb accepted this revision.Sep 15 2021, 11:15 PM

This revision is now accepted and ready to land.Sep 15 2021, 11:15 PM

Closed by commit rGf575573ca577: Remove PT_GET_SC_ARGS_ALL (authored by kib). · Explain WhySep 16 2021, 5:28 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGf575573ca577: Remove PT_GET_SC_ARGS_ALL.

trasz added a commit: rG4cae9d803a95: Remove PT_GET_SC_ARGS_ALL.Feb 21 2022, 1:50 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 21 2022, 1:50 PM

Revision Contents
Changeset List

Path

Size

lib/

libsysdecode/

2 lines

sys/

amd64/

linux/

18 lines

compat/

freebsd32/

freebsd32_misc.c

3 lines

kern/

1 line

23 lines

sys/

4 lines

Diff 95256

lib/libsysdecode/mktables

Loading...

sys/amd64/linux/linux_ptrace.c

Loading...

sys/compat/freebsd32/freebsd32_misc.c

Loading...

sys/kern/kern_thread.c

Loading...

sys/kern/sys_process.c

Loading...

sys/sys/ptrace.h

Loading...