Differential D31922

ctl(4): Do hole-punching for UNMAP to file-backed LUNs
ClosedPublic
Actions

Authored by khng on Sep 12 2021, 7:17 PM.

Details

Reviewers

mav

Group Reviewers

cam

Commits

rG49050613ef1f: ctl(4): Do hole-punching for UNMAP to file-backed LUNs

Summary

This adds support for SCSI UNMAP command to file-backed LUNs, if the
underlying file system has a non-zerofilling VOP_DEALLOCATE
implementation where some or all parts of the requested operation range
may be deallocated.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

khng created this revision.Sep 12 2021, 7:17 PM

Herald added a reviewer: cam. · View Herald TranscriptSep 12 2021, 7:17 PM

Herald added a subscriber: imp. · View Herald Transcript

khng requested review of this revision.Sep 12 2021, 7:17 PM

Harbormaster completed remote builds in B41474: Diff 95013.Sep 12 2021, 7:17 PM

khng added a reviewer: mav.Sep 13 2021, 8:36 AM

mav added inline comments.Sep 13 2021, 1:30 PM

sys/cam/ctl/ctl_backend_block.c
911	Should here be vn_finished_write(mp)?

Thanks mav@ for pointing this mistake out.

Harbormaster completed remote builds in B41482: Diff 95047.Sep 13 2021, 4:26 PM

mav accepted this revision.Sep 13 2021, 4:27 PM

This revision is now accepted and ready to land.Sep 13 2021, 4:27 PM

Closed by commit rG49050613ef1f: ctl(4): Do hole-punching for UNMAP to file-backed LUNs (authored by khng). · Explain WhySep 14 2021, 7:52 PM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rG49050613ef1f: ctl(4): Do hole-punching for UNMAP to file-backed LUNs.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl_backend_block.c

99 lines

Diff 95161

View Options

sys/cam/ctl/ctl_backend_block.c

ctl(4): Do hole-punching for UNMAP to file-backed LUNsClosedPublicActions