Page MenuHomeFreeBSD

pf: qid and pqid can be uint16_t
ClosedPublic

Authored by kp on Sep 7 2021, 2:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 26, 7:51 AM
Unknown Object (File)
Apr 19 2026, 12:54 PM
Unknown Object (File)
Apr 17 2026, 11:14 PM
Unknown Object (File)
Apr 14 2026, 9:52 PM
Unknown Object (File)
Apr 12 2026, 2:32 AM
Unknown Object (File)
Mar 31 2026, 1:17 PM
Unknown Object (File)
Mar 27 2026, 9:26 AM
Unknown Object (File)
Mar 19 2026, 3:33 AM

Details

Summary

tag2name() returns a uint16_t, so we don't need to use uint32_t for the
qid (or pqid). This reduces the size of struct pf_kstate slightly. That
in turn buys us space to add extra fields for dummynet later.

Happily these fields are not exposed to user space (there are user space
versions of them, but they can just stay uint32_t), so there's no ABI
breakage in modifying this.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable