Page MenuHomeFreeBSD

pf: qid and pqid can be uint16_t
ClosedPublic

Authored by kp on Sep 7 2021, 2:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 27, 8:03 PM
Unknown Object (File)
Tue, May 27, 6:00 AM
Unknown Object (File)
Sun, May 11, 10:47 AM
Unknown Object (File)
Mon, May 5, 4:46 AM
Unknown Object (File)
Apr 11 2025, 11:38 PM
Unknown Object (File)
Apr 8 2025, 4:00 PM
Unknown Object (File)
Apr 7 2025, 12:19 PM
Unknown Object (File)
Feb 18 2025, 8:47 PM

Details

Summary

tag2name() returns a uint16_t, so we don't need to use uint32_t for the
qid (or pqid). This reduces the size of struct pf_kstate slightly. That
in turn buys us space to add extra fields for dummynet later.

Happily these fields are not exposed to user space (there are user space
versions of them, but they can just stay uint32_t), so there's no ABI
breakage in modifying this.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable