Page MenuHomeFreeBSD

sctp: Fix iterator synchronization in sctp_sendall()
ClosedPublic

Authored by markj on Sep 2 2021, 9:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 12 2024, 9:26 PM
Unknown Object (File)
Feb 13 2024, 1:08 PM
Unknown Object (File)
Dec 25 2023, 1:28 AM
Unknown Object (File)
Dec 22 2023, 11:32 PM
Unknown Object (File)
Dec 14 2023, 8:39 PM
Unknown Object (File)
Nov 30 2023, 8:44 PM
Unknown Object (File)
Nov 9 2023, 2:54 AM
Unknown Object (File)
Nov 5 2023, 10:14 PM
Subscribers

Details

Summary
- The SCTP_PCB_FLAGS_SND_ITERATOR_UP check was racy, since two threads
  could observe that the flag is not set and then both set it.  I'm not
  sure if this is actually a problem in practice, i.e., maybe there's no
  problem having multiple sends for a single PCB in the iterator list?
- sctp_sendall() was modifying sctp_flags without the inp lock held.

The change simply acquires the PCB write lock before toggling the flag,
fixing both problems.

N.B., sctp_sendall() seems buggy for other reasons: it appears to handle
uio == NULL (taking the input mbuf instead) but unconditionally
dereferences uio.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable