Page MenuHomeFreeBSD

sctp: Fix iterator synchronization in sctp_sendall()
ClosedPublic

Authored by markj on Sep 2 2021, 9:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 4:15 PM
Unknown Object (File)
Wed, Oct 15, 4:15 PM
Unknown Object (File)
Wed, Oct 15, 4:15 PM
Unknown Object (File)
Wed, Oct 15, 5:24 AM
Unknown Object (File)
Sat, Oct 11, 9:13 PM
Unknown Object (File)
Sat, Oct 11, 5:21 PM
Unknown Object (File)
Sat, Oct 11, 2:33 PM
Unknown Object (File)
Sat, Oct 11, 2:33 PM
Subscribers

Details

Summary
- The SCTP_PCB_FLAGS_SND_ITERATOR_UP check was racy, since two threads
  could observe that the flag is not set and then both set it.  I'm not
  sure if this is actually a problem in practice, i.e., maybe there's no
  problem having multiple sends for a single PCB in the iterator list?
- sctp_sendall() was modifying sctp_flags without the inp lock held.

The change simply acquires the PCB write lock before toggling the flag,
fixing both problems.

N.B., sctp_sendall() seems buggy for other reasons: it appears to handle
uio == NULL (taking the input mbuf instead) but unconditionally
dereferences uio.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable