Differential D31732

sctp: Avoid unnecessary refcount bumps in sctp_inpcb_bind()
ClosedPublic
Actions

Authored by markj on Aug 30 2021, 9:26 PM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rG93908fce7280: sctp: Avoid unnecessary refcount bumps in sctp_inpcb_bind()

Summary

We only drop the inp lock when binding to a specific port. So, only
acquire an extra reference when required. This simplifies error
handling a bit.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 30 2021, 9:26 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 30 2021, 9:26 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

markj requested review of this revision.Aug 30 2021, 9:26 PM

Harbormaster completed remote builds in B41270: Diff 94393.Aug 30 2021, 9:26 PM

markj added a parent revision: D31731: sctp: Remove always-false checks in sctp_inpcb_bind().Aug 30 2021, 9:26 PM

markj added a child revision: D31733: sctp: Simplify the free port search in sctp_inpcb_bind().

tuexen accepted this revision.Aug 31 2021, 9:43 AM

This revision is now accepted and ready to land.Aug 31 2021, 9:43 AM

Closed by commit rG93908fce7280: sctp: Avoid unnecessary refcount bumps in sctp_inpcb_bind() (authored by markj). · Explain WhyAug 31 2021, 11:47 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG93908fce7280: sctp: Avoid unnecessary refcount bumps in sctp_inpcb_bind().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

sctp_pcb.c

10 lines

Diff 94429

View Options

sctp: Avoid unnecessary refcount bumps in sctp_inpcb_bind()ClosedPublicActions