igb(4): Update and fix HW errata

[erj]

Summary

• Shared code api for EEE changed
• HW errata workaround for IPv6 offload w/ extension headers
• Edited start of if_igb.c (Device IDs / #includes) to match ixgbe/ixl

[sbruno]

sys/dev/e1000/if_igb.c

544

true instead of TRUE?

[sbruno]

sys/dev/e1000/if_igb.c

98

Uh ... did you mean to delete all these header files?

[erj]

sys/dev/e1000/if_igb.c

98

They were supposed to have been moved to if_igb.h...I think I need to re-upload this revision.

544

I like the lowercase version because it gets colored differently in vim, but in the end, if it makes it more consistent, maybe we should use the uppercase version.

[erj]

• Added includes to start of if_igb.h that were mistakenly left out in the initial diff.

[sbruno]

This update seems to fail to apply at all. I get numerous errors about patches being already applied. Can you regenerate against a clean checkout?

[erj]

In D3165#71223, @sbruno wrote:

This update seems to fail to apply at all. I get numerous errors about patches being already applied. Can you regenerate against a clean checkout?

I'll try.

[erj]

Regenerate if_igb.[ch] changes, hopefully without the extra commits.

[erj]

Oh geez, I didn't realize Arcanist would grab the commit messages and commits from my local tree automatically. Hrm.

[sbruno]

I've committed this at svn r287465.

I skipped the update to the EEE functions and will do that in the shared code update for e1000

[erj]

@sbruno,

Before I update D3162, was Oliver Hartmann's (or someone else's) original issue with the i210 solved? I remember hearing from you that it was, and we still can't find a problem with i210 using the code that's in D3162, but I wanted to make sure we knew what the actual problem was.

Maybe I can re-add the I210_OBFF_SUPPORT section, but since that option wasn't defined in the Makefile by default, I doubt anyone used it.

[erj]

Quick re-open until I get an answer to the last comment.

[sbruno]

In D3165#102440, @erj wrote:

@sbruno,

Before I update D3162, was Oliver Hartmann's (or someone else's) original issue with the i210 solved? I remember hearing from you that it was, and we still can't find a problem with i210 using the code that's in D3162, but I wanted to make sure we knew what the actual problem was.

Maybe I can re-add the I210_OBFF_SUPPORT section, but since that option wasn't defined in the Makefile by default, I doubt anyone used it.

This was the oringal thread.

https://lists.freebsd.org/pipermail/freebsd-current/2015-September/057483.html

[erj]

I think I recall you saying that he ended up getting his i210 working again? But I can't remember if it's with the new igb code or he got the reverted version working again. I'll reply to the thread.