Page MenuHomeFreeBSD

math/lapack: remove superfluous and broken ranlib invocation
ClosedPublic

Authored by emaste on Aug 10 2021, 4:08 PM.
Tags
None
Referenced Files
F87318306: D31492.id93503.diff
Mon, Jul 1, 5:25 PM
Unknown Object (File)
Mon, Jul 1, 6:46 AM
Unknown Object (File)
Thu, Jun 27, 6:16 PM
Unknown Object (File)
Mon, Jun 17, 6:31 PM
Unknown Object (File)
Sat, Jun 15, 4:46 PM
Unknown Object (File)
Thu, Jun 13, 12:52 AM
Unknown Object (File)
Wed, Jun 12, 10:39 AM
Unknown Object (File)
Tue, Jun 4, 12:30 PM
Subscribers

Details

Summary
FreeBSD's base system ar and ranlib have a bug where they exit with
status 0 (success) even in case of fatal errors, which hid the fact that
math/lapacke was invoking ranlib on a non-existent file.  (Presumably the
ranlib invocation was correct when introduced, but broken by some
rework of lapack's upstream build system).

Use of ranlib is unncessary assuming the -s flag is passed to ar (it is
here), so just remove it.

PR: 257744
Sponsored by:   The FreeBSD Foundation
Test Plan

Verify math/lapacke builds and inspect build log to ensure ar contains -s flag

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
emaste added a reviewer: Ports Committers.
kevans added a subscriber: kevans.

Confirm it builds under poudriere testport then

Approved by: kevans (ports), portmgr (implicit, blanket: build fix)
This revision is now accepted and ready to land.Aug 10 2021, 8:42 PM
jrm accepted this revision as: jrm.EditedAug 10 2021, 8:45 PM
jrm added a subscriber: jrm.

Ran testport for 11amd64, 12i386, 12amd64, and 13amd64 for math/lapack, math/blas, math/cblas, math/lapacke, and math/xlapack. Everything looks fine.

(Also for posterity, PORTREVISION bump not necessary as the removed command had no effect.)