mount_nfs: Be more clear on nmount(2) error with errmsg unset
ClosedPublic
Actions

Authored by cem on Jul 22 2015, 3:07 AM.

Details

Reviewers

markj
rmacklem
trasz

Commits

rS285804: mount_nfs: Be more clear on nmount(2) error with errmsg unset

Summary

Minor cleanup.

mount_nfs: nmount: /mnt/NAS: Operation not supported by device

was:

mount_nfs: /mnt/NAS, : Operation not supported by device

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem updated this revision to Diff 7162.Jul 22 2015, 3:07 AM

cem retitled this revision from to mount_nfs: Be more clear on nmount(2) error with errmsg unset.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added reviewers: markj, rmacklem, trasz.

Herald added a subscriber: imp. · View Herald TranscriptJul 22 2015, 3:07 AM

Yea, looks fine to me.

This revision is now accepted and ready to land.Jul 22 2015, 10:25 PM

bdrewery added a subscriber: bdrewery.Jul 22 2015, 10:33 PM

bdrewery added inline comments.

sbin/mount_nfs/mount_nfs.c
479 ↗	(On Diff #7162)	Missing space before `?'.

cem added inline comments.Jul 22 2015, 10:49 PM

sbin/mount_nfs/mount_nfs.c
479 ↗	(On Diff #7162)	Should there be a space there?

markj accepted this revision.Jul 22 2015, 10:49 PM

markj edited edge metadata.

Add a space.

This revision now requires review to proceed.Jul 22 2015, 10:51 PM

bdrewery added inline comments.Jul 22 2015, 10:53 PM

sbin/mount_nfs/mount_nfs.c
479 ↗	(On Diff #7162)	The most common style is to have a space before it. % git grep '[^ ]?.:' -- 'sys/.c'\|wc -l 854 % git grep '[ ]?.:' -- 'sys/.c'\|wc -l 10121

Closed by commit rS285804: mount_nfs: Be more clear on nmount(2) error with errmsg unset (authored by cem). · Explain WhyJul 22 2015, 10:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

mount_nfs/

mount_nfs.c

3 lines

Diff 7195

View Options

head/sbin/mount_nfs/mount_nfs.c

mount_nfs: Be more clear on nmount(2) error with errmsg unsetClosedPublicActions