iscsi: Remove icl_soft-only fields from struct icl_conn.

[jhb]

Summary

Create a struct icl_soft_conn which extends struct icl_conn and
move fields only used by icl_soft from struct icl_conn to
struct icl_soft_conn.

Sponsored by: Chelsio Communications

[mav]

With few comments it is fine for me. Few more fields could be made driver specific, but they are used at least by soft and cxgbei.

sys/dev/iscsi/icl_soft.c

79

I'd move receive_cv one line up, both alphabetically and by size, unless you had some other idea here.

735

Some disagree, but I personally prefer such assignment done up in definition lines.

[jhb]

sys/dev/iscsi/icl_soft.c

79

I'd move receive_cv one line up, both alphabetically and by size, unless you had some other idea here.

735

I actually used it a fair bit in other places in this patch. I had only done it here to match existing style. The recent update to style(9) permits it when assigning values that don't change (which is true for both of these and things like softc pointers, etc.).