Page MenuHomeFreeBSD

RK817 driver
AbandonedPublic

Authored by sos on Jul 28 2021, 10:18 AM.

Details

Reviewers
manu
mmel
Group Reviewers
arm64
Summary

Driver for the power part of the RK817

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sos requested review of this revision.Jul 28 2021, 10:18 AM

Can't this be adapted to the k805 driver ?

It could, but it gets ugly, and the driver/file name should then be something like rk8xx instead. However the 816/817 has lots more functionality so it might make sense in the long run to keep it separate.

In D31331#705749, @sos wrote:

It could, but it gets ugly, and the driver/file name should then be something like rk8xx instead. However the 816/817 has lots more functionality so it might make sense in the long run to keep it separate.

What functionality it has over rk80x ?
Also even if we make it a separate driver here you mainly copy rk805.c code but removed the copyright to add only yours, this is not correct.

Having looked more into the PMIC's on the Q64 it is somewhat of a mess, they should be located in /sys/dev/iicbus/pmic as they are not either arm64 or rockchip specific, however down there it is even more of a mess as some are I the pic dir some are not, there are even some that are in both :). I'll look into getting the rk8xx pmic's supported by one driver at at least in "myBSD" put them in the right place together with support for the CPU one which is already partly there..
What happened to getting things put in the right places ? much of the arm/arm64 support is a royal mess as is, I stumbled over this when I did Marvell support for the espressobin as well...
The copyright is easily fixed, just at oversight as that file emerged from at empty templete here and I forgot it...