This fixes the GH action CI run.
What do you mean by that? I see that this run no longer has the debug output that I added, but it is/was running the homebrew lld and then falling flat on its face.
Here's a run with -dx showing that LD=/usr/local/opt/llvm/bin/ld.lld
Yes, the bootstrap-tools/build-tools phase wants the Mach-O linker (LINKER_TYPE==mac), the later phases want lld since we are cross-compiling FreeBSD ELF files. So when building we want LD=/usr/bin/ld XLD=/usr/local/opt/llvm/bin/ld.lld (which should be the values that make.py sets).
I just ran arc diff --update D31231 which doesn't seem to pull in the new message, it now reads:
Make it clear we're running clang-12 for the GH actions This chases a homebrew change in the default clang version. Reviewers: arichardson Subscribers: bdrewery, imp, emaste Differential Revision: https://reviews.freebsd.org/D31231