Differential D31136

pf: Remove unused arguments from pf_send_tcp()
ClosedPublic
Actions

Authored by kp on Jul 11 2021, 8:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 12, 7:09 AM

	Unknown Object (File)
	Feb 22 2025, 12:29 AM

	Unknown Object (File)
	Feb 9 2025, 5:16 PM

	Unknown Object (File)
	Feb 9 2025, 5:08 PM

	Unknown Object (File)
	Feb 6 2025, 1:23 AM

	Unknown Object (File)
	Feb 3 2025, 11:50 PM

	Unknown Object (File)
	Dec 3 2024, 6:41 AM

	Unknown Object (File)
	Nov 30 2024, 11:58 AM

View All 91 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG823c2bd77b6e: pf: Remove unused arguments from pf_send_tcp()
rG33222b6f8af8: pf: Remove unused arguments from pf_send_tcp()
rG295f2d939d96: pf: Remove unused arguments from pf_send_tcp()

Summary

struct mbuf *replyto is not actually used (and only rarely provided).
The same applies to struct ifnet *ifp.

No functional change.

MFC after: 1 week
Sponsored by: Modirum MDPay

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jul 11 2021, 8:17 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptJul 11 2021, 8:17 AM

kp requested review of this revision.Jul 11 2021, 8:17 AM

Harbormaster completed remote builds in B40432: Diff 92065.Jul 11 2021, 8:17 AM

mjg accepted this revision.Jul 11 2021, 7:29 PM

This revision is now accepted and ready to land.Jul 11 2021, 7:29 PM

Closed by commit rG295f2d939d96: pf: Remove unused arguments from pf_send_tcp() (authored by kp). · Explain WhyJul 17 2021, 2:00 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG295f2d939d96: pf: Remove unused arguments from pf_send_tcp().

kp added a commit: rG33222b6f8af8: pf: Remove unused arguments from pf_send_tcp().Jul 24 2021, 8:02 PM

kp added a commit: rG823c2bd77b6e: pf: Remove unused arguments from pf_send_tcp().

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

42 lines

Diff 92303

sys/netpfil/pf/pf.c

	TIMESTAMP = 1487153232			TIMESTAMP = 1492677491
	SHA256 (concourse-2.7.0.tar.xz) = 06e2df43110d728a9f25e7df8636059f6642d1709af7f265b5e644713027ae3a			SHA256 (concourse-2.7.3.tar.xz) = 3ba3f0cf5b373b1f15f4231e16546997a93b7cdc79f1ce2693a4110de68e1866
	SIZE (concourse-2.7.0.tar.xz) = 8977848			SIZE (concourse-2.7.3.tar.xz) = 9026616