Paths

Table of Contentst

Differential D31093

Update the arm64 HCR_EL2 registers
ClosedPublic
Actions

Authored by andrew on Jul 7 2021, 4:16 PM.

Tags

None

Referenced Files

	F132517668: D31093.id92215.diff
	Fri, Oct 17, 2:33 PM

	F132517667: D31093.id.diff
	Fri, Oct 17, 2:33 PM

	F132517665: D31093.id91939.diff
	Fri, Oct 17, 2:33 PM

	F132517664: D31093.id91964.diff
	Fri, Oct 17, 2:33 PM

	F132474520: D31093.diff
	Fri, Oct 17, 5:50 AM

	Unknown Object (File)
	Sat, Sep 20, 3:37 PM

	Unknown Object (File)
	Sep 6 2025, 3:22 AM

	Unknown Object (File)
	Sep 5 2025, 3:57 PM

View All 91 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG535a5779e2c4: Update the arm64 HCR_EL2 registers
rG3c1bfadaf93d: Update the arm64 HCR_EL2 registers

Summary

They are valid as of the ARMv8.7 XML.

While here switch to use shifted values as they are easier to compare
with values in the Arm Reference Manual.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jul 7 2021, 4:16 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 7 2021, 4:16 PM

Herald added a subscriber: imp. · View Herald Transcript

andrew requested review of this revision.Jul 7 2021, 4:16 PM

Harbormaster completed remote builds in B40369: Diff 91939.Jul 7 2021, 4:16 PM

emaste added inline comments.Jul 7 2021, 4:56 PM

sys/arm64/include/hypervisor.h
5	Maybe "... developed in part ..." (or "Portions of this software...")? Not really a big deal but much of this file predates any FF involvement, and this statement makes it sound as if the entirety is FF sponsored.
55–95	Is `UL()` typical (in reference docs or other arm64 files)? Examples like `1U << 3` below look more natural to me.

Update the sponsorship text

Harbormaster completed remote builds in B40387: Diff 91964.Jul 8 2021, 7:51 AM

andrew added inline comments.Jul 14 2021, 4:22 PM

sys/arm64/include/hypervisor.h
55–95	It's because we can't use `1UL << 3` in assembly, and these macros are often needed there. The macro is defined in `armreg.h`

This revision was not accepted when it landed; it landed in state Needs Review.Jul 15 2021, 9:23 AM

Closed by commit rG3c1bfadaf93d: Update the arm64 HCR_EL2 registers (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG3c1bfadaf93d: Update the arm64 HCR_EL2 registers.

andrew added a commit: rG535a5779e2c4: Update the arm64 HCR_EL2 registers.Aug 6 2021, 12:52 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

113 lines

Diff 92215

sys/arm64/include/hypervisor.h

Loading...