Page MenuHomeFreeBSD
Differential D3108

Fix bounds checks for kernel stack on x86.
ClosedPublic
Actions

Authored by kib on Jul 16 2015, 10:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 7 2024, 1:28 PM
Unknown Object (File)
Nov 7 2024, 1:21 PM
Unknown Object (File)
Nov 5 2024, 12:53 PM
Unknown Object (File)
Nov 4 2024, 6:11 PM
Unknown Object (File)
Oct 2 2024, 7:57 AM
Unknown Object (File)
Sep 30 2024, 3:20 AM
Unknown Object (File)
Sep 27 2024, 10:30 PM
Unknown Object (File)
Sep 25 2024, 4:20 AM
View All 57 Files
Subscribers
andrew
imp

Details

Reviewers
emaste
markj
gnn
wma_semihalf.com

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib updated this revision to Diff 7008.Jul 16 2015, 10:01 AM
kib retitled this revision from to Fix bounds checks for kernel stack on x86..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added reviewers: wma_semihalf.com, emaste.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJul 16 2015, 10:01 AM
andrew added a subscriber: andrew.Jul 16 2015, 10:15 AM

I think there is a similar issue in sys/cddl/dev/dtrace/amd64/dtrace_isa.c and sys/cddl/dev/dtrace/i386/dtrace_isa.c

kib updated this revision to Diff 7012.Jul 16 2015, 10:37 AM

Fix places in the dtrace machdep code, noted by andrew.

Herald added a reviewer: gnn. · View Herald TranscriptJul 16 2015, 10:37 AM
kib added a reviewer: markj.Jul 16 2015, 11:36 AM
markj accepted this revision.Jul 16 2015, 5:49 PM
markj edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 5:49 PM
emaste accepted this revision.Jul 16 2015, 6:57 PM
emaste edited edge metadata.

Looks fine to me.

kib closed this revision.Jul 16 2015, 7:44 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
10 lines
cddl/
dev/
dtrace/
amd64/
8 lines
i386/
8 lines
i386/
i386/
10 lines

Diff 7012

View Options

sys/amd64/amd64/stack_machdep.c

Loading...
View Options

sys/cddl/dev/dtrace/amd64/dtrace_isa.c

Loading...
View Options

sys/cddl/dev/dtrace/i386/dtrace_isa.c

Loading...
View Options

sys/i386/i386/stack_machdep.c

Loading...