Page MenuHomeFreeBSD
Differential D31038

rtld/tests: Avoid function name conflict with libc opendir()
ClosedPublic
Actions

Authored by arichardson on Jul 5 2021, 8:40 AM.

Details

Reviewers
oshogbo
kib
markj
Commits
rGe34c713b0e66: rtld/tests: Avoid function name conflict with libc opendir()
Summary

This prevents these tests from being compiled with ASAN since the asan
interceptors also define opendir() but matching the libc function.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.Jul 5 2021, 8:40 AM
Herald added subscribers: bdragon, imp. · View Herald TranscriptJul 5 2021, 8:40 AM
arichardson requested review of this revision.Jul 5 2021, 8:40 AM
Harbormaster completed remote builds in B40285: Diff 91758.Jul 5 2021, 8:40 AM
kib accepted this revision.Jul 5 2021, 8:59 AM
This revision is now accepted and ready to land.Jul 5 2021, 8:59 AM
oshogbo accepted this revision.Jul 5 2021, 9:33 AM

We have fdopendir in libc I wonder if this won't be confusing. Maybe we should rename this to something like rtld_opendir.
But whatever name your choose this LGTM.

markj accepted this revision.Jul 5 2021, 11:46 AM
Closed by commit rGe34c713b0e66: rtld/tests: Avoid function name conflict with libc opendir() (authored by arichardson). · Explain WhyJul 6 2021, 10:07 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGe34c713b0e66: rtld/tests: Avoid function name conflict with libc opendir().

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
tests/
2 lines
2 lines
4 lines
2 lines

Diff 91868

View Options

libexec/rtld-elf/tests/common.h

Loading...
View Options

libexec/rtld-elf/tests/common.c

Loading...
View Options

libexec/rtld-elf/tests/ld_library_pathfds.c

Loading...
View Options

libexec/rtld-elf/tests/ld_preload_fds.c

Loading...