sys/netinet: handle IPv4 PMTU Discovery
Needs ReviewPublic
Actions

Authored by wma on Jul 2 2021, 4:37 AM.

Tags

None

Referenced Files

	F135962733: D30991.id91641.diff
	Fri, Nov 14, 2:55 PM

	Unknown Object (File)
	Wed, Nov 12, 2:33 PM

	Unknown Object (File)
	Sat, Nov 1, 7:02 AM

	Unknown Object (File)
	Sat, Oct 25, 5:42 PM

	Unknown Object (File)
	Sat, Oct 25, 3:22 PM

	Unknown Object (File)
	Sat, Oct 25, 2:59 PM

	Unknown Object (File)
	Oct 14 2025, 1:06 PM

	Unknown Object (File)
	Oct 14 2025, 1:05 PM

View All 85 Files

Subscribers

melifaro

Details

Reviewers

mw
imp
np
tuexen

Summary

On input ICMP handler is updating tcp_hostcache with the PMTU value.
On output calculate MTU based on the route/interface and hostcache.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wma created this revision.Jul 2 2021, 4:37 AM

Herald added a subscriber: melifaro. · View Herald TranscriptJul 2 2021, 4:37 AM

wma requested review of this revision.Jul 2 2021, 4:37 AM

SCTP and TCP do a similar handling, but only after performing some checks (port numbers and vtag in case of SCTP, port numbers and sequence number in case of TCP) to make it non-trivial for an off-path attacker to generate an ICMP message, which will be accepted and the corresponding MTU will be cached.

How is such an check done in this context?

wma updated this revision to Diff 92414.Jul 19 2021, 11:16 AM

Good point. I removed all *input processing and left only *output check, which might be worth to have it in one place as we don't update mtu here anyway. Also pushed some changes to UDP ctlinput to match https://reviews.freebsd.org/D30992