Page MenuHomeFreeBSD

LinuxKPI: add module_pci_driver() and pci_alloc_irq_vectors()
ClosedPublic

Authored by bz on Jul 1 2021, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 7:01 AM
Unknown Object (File)
Sep 4 2025, 3:03 PM
Unknown Object (File)
Aug 25 2025, 8:52 PM
Unknown Object (File)
Aug 21 2025, 1:40 AM
Unknown Object (File)
Aug 14 2025, 10:16 AM
Unknown Object (File)
Aug 12 2025, 12:18 AM
Unknown Object (File)
Aug 11 2025, 9:31 AM
Unknown Object (File)
Aug 8 2025, 12:45 AM

Details

Summary

Add the two new functions needed by rtw88 to register the driver and
handle the module bits as well as a version of pci_alloc_irq_vectors()
for what is needed.

MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Jul 1 2021, 1:35 PM
hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/pci.h
848

What about MSIX IRQ's ? Can you add a test for that aswell?

854

I think this comment can be removed. No need to allocate.

sys/compat/linuxkpi/common/include/linux/pci.h
848

I can put a similar block; what's the #define? PCI_IRQ_MSIX? I don't have a driver using that.

sys/compat/linuxkpi/common/include/linux/pci.h
848

Just define it and add relevant calls for pci_enable_msix().

Should be fairly trivial.

include/linux/pci.h:#define PCI_IRQ_MSIX (1 << 2) /* Allow MSI-X interrupts */

This revision is now accepted and ready to land.Jul 2 2021, 12:33 PM