libpfctl: memory leak fix
ClosedPublic
Actions

Authored by kp on Jun 30 2021, 1:12 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGe553299fd630: libpfctl: memory leak fix
rG4debb6a3a027: libpfctl: memory leak fix
rG0e9f1892ec73: libpfctl: memory leak fix

Summary

We must remember to free the nvlist we create from the kernel's response
to DIOCGETSTATESNV, on every iteration.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jun 30 2021, 1:12 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 30 2021, 1:12 PM

kp requested review of this revision.Jun 30 2021, 1:12 PM

Harbormaster completed remote builds in B40185: Diff 91561.Jun 30 2021, 1:12 PM

kp added a parent revision: D30956: pf: constant for the nvlist state size hint.Jun 30 2021, 1:12 PM

Why does it depend on other reviews?
If it's part of an open review, please fix it there.
If not, please fix it regardless of the other changes.

In D30957#696739, @donner wrote:

Why does it depend on other reviews?
If it's part of an open review, please fix it there.
If not, please fix it regardless of the other changes.

It's a bug that was already present, but will be made more serious by D30948.
I've linked it to the other reviews because they all deal with the same code, and this patch likely won't apply without those other patches (although it could indeed be committed independently).

donner accepted this revision as: donner.Jul 1 2021, 7:54 AM

This revision is now accepted and ready to land.Jul 1 2021, 7:54 AM

Closed by commit rG0e9f1892ec73: libpfctl: memory leak fix (authored by kp). · Explain WhyJul 2 2021, 1:50 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG0e9f1892ec73: libpfctl: memory leak fix.

kp added a commit: rG4debb6a3a027: libpfctl: memory leak fix.Jul 9 2021, 1:25 PM

kp added a commit: rGe553299fd630: libpfctl: memory leak fix.