libpfctl: read states in multiple calls
AbandonedPublic
Actions

Authored by kp on Jun 29 2021, 7:39 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Summary

Default to retrieving a tenth of the states at a time. This reduces the
total memory requirements to retrieve all states, and also reducing the
time the process becomes uninterruptible.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40298
Build 37187: arc lint + arc unit

Event Timeline

kp created this revision.Jun 29 2021, 7:39 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 29 2021, 7:39 PM

kp requested review of this revision.Jun 29 2021, 7:39 PM

Harbormaster completed remote builds in B40175: Diff 91525.Jun 29 2021, 7:39 PM

kp added a parent revision: D30947: pf: support paging in the DIOCGETSTATESNV call.Jun 29 2021, 7:39 PM

kp added a child revision: D30956: pf: constant for the nvlist state size hint.Jun 30 2021, 1:12 PM

kp mentioned this in D30957: libpfctl: memory leak fix.Jul 1 2021, 6:52 AM

Address review remarks

Harbormaster completed remote builds in B40298: Diff 91781.Jul 5 2021, 11:50 AM

should this be closed?

Yes, this is not needed any more. I thought I'd abandoned all of the obsolete attempts at fixing this, but is seems I missed this one.

Revision Contents
Changeset List

Path

Size

lib/

libpfctl/

libpfctl.c

62 lines

Diff 91781

View Options

libpfctl: read states in multiple callsAbandonedPublicActions