arm64: remove an unneeded test from pmap_clear_modify()
ClosedPublic
Actions

Authored by alc on Jun 23 2021, 5:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 11, 8:06 PM

	Unknown Object (File)
	Sat, Sep 26, 7:39 AM

	Unknown Object (File)
	Fri, Sep 25, 5:18 PM

	Unknown Object (File)
	Sep 13 2026, 1:56 AM

	Unknown Object (File)
	Sep 11 2026, 4:10 PM

	Unknown Object (File)
	Sep 7 2026, 10:07 PM

	Unknown Object (File)
	Sep 7 2026, 8:32 PM

	Unknown Object (File)
	Sep 7 2026, 12:42 PM

View All Files

Subscribers

emaste

Details

Reviewers

andrew
kib
markj
manu

Commits

rG62ea198e95f1: arm64: remove an unneeded test from pmap_clear_modify()

Summary

The page table entry for a 4KB page mapping must be valid if a PV entry for the mapping exists, so there is no point in testing each page table entry's validity when iterating over a PV list.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Jun 23 2021, 5:33 AM

Herald added a reviewer: manu. · View Herald TranscriptJun 23 2021, 5:33 AM

Herald added a subscriber: emaste. · View Herald Transcript

alc requested review of this revision.Jun 23 2021, 5:33 AM

kib accepted this revision.Jun 23 2021, 5:54 AM

This revision is now accepted and ready to land.Jun 23 2021, 5:54 AM

markj accepted this revision.Jun 23 2021, 12:57 PM

Closed by commit rG62ea198e95f1: arm64: remove an unneeded test from pmap_clear_modify() (authored by alc). · Explain WhyJun 23 2021, 7:29 PM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rG62ea198e95f1: arm64: remove an unneeded test from pmap_clear_modify().

Revision Contents
Changeset List

Path

Size

sys/

arm64/

pmap.c

3 lines

Diff 91273

View Options

arm64: remove an unneeded test from pmap_clear_modify()ClosedPublicActions