arm64: remove an unneeded test from pmap_clear_modify()
ClosedPublic
Actions

Authored by alc on Jun 23 2021, 5:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 7, 10:26 AM

	Unknown Object (File)
	Sat, Nov 1, 5:22 PM

	Unknown Object (File)
	Wed, Oct 15, 8:53 PM

	Unknown Object (File)
	Mon, Oct 13, 6:45 AM

	Unknown Object (File)
	Sep 29 2025, 12:37 AM

	Unknown Object (File)
	Sep 18 2025, 11:22 AM

	Unknown Object (File)
	Sep 18 2025, 1:59 AM

	Unknown Object (File)
	Sep 5 2025, 8:02 AM

View All 79 Files

Subscribers

emaste

Details

Reviewers

andrew
kib
markj
manu

Commits

rG62ea198e95f1: arm64: remove an unneeded test from pmap_clear_modify()

Summary

The page table entry for a 4KB page mapping must be valid if a PV entry for the mapping exists, so there is no point in testing each page table entry's validity when iterating over a PV list.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Jun 23 2021, 5:33 AM

Herald added a reviewer: manu. · View Herald TranscriptJun 23 2021, 5:33 AM

Herald added a subscriber: emaste. · View Herald Transcript

alc requested review of this revision.Jun 23 2021, 5:33 AM

kib accepted this revision.Jun 23 2021, 5:54 AM

This revision is now accepted and ready to land.Jun 23 2021, 5:54 AM

markj accepted this revision.Jun 23 2021, 12:57 PM

Closed by commit rG62ea198e95f1: arm64: remove an unneeded test from pmap_clear_modify() (authored by alc). · Explain WhyJun 23 2021, 7:29 PM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rG62ea198e95f1: arm64: remove an unneeded test from pmap_clear_modify().

Revision Contents
Changeset List

Path

Size

sys/

arm64/

pmap.c

3 lines

Diff 91273

View Options

arm64: remove an unneeded test from pmap_clear_modify()ClosedPublicActions