Page MenuHomeFreeBSD
Differential D30831

genet: pullup minimum header amount for IPv4
ClosedPublic
Actions

Authored by • karels on Jun 20 2021, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 11:40 PM
Unknown Object (File)
Mon, Jan 27, 7:40 AM
Unknown Object (File)
Sat, Jan 25, 7:50 PM
Unknown Object (File)
Sat, Jan 25, 7:13 PM
Unknown Object (File)
Sat, Jan 18, 5:18 PM
Unknown Object (File)
Fri, Jan 17, 5:34 PM
Unknown Object (File)
Wed, Jan 15, 8:23 PM
Unknown Object (File)
Wed, Jan 15, 1:02 AM
View All 84 Files
Subscribers
andrew
emaste

Details

Reviewers
manu
imp
emaste
Commits
rG2ecf3f2c5774: genet: pullup minimum header amount for IPv4
rG184291b0a56a: genet: pullup minimum header amount for IPv4
Summary

The genet driver (RPi4 Ethernet) had code to pull headers into the
first mbuf if there was only an Ethernet header there. This was
originally needed for ICMPv6 replies, then for forwarded IPv6/TCP.
Now a situation has been found where it is needed for IPv4, when
using NAT with IPFW. Generalize to do this for all protocols.
Rather than using an IPv6-related definition for the length, move
the length to a variable that can be set with sysctl
(hw.genet.tx_hdr_min). Move an old tunable to a new RDTUN variable
with a better name.

PR: 25607

Test Plan

tested by users that reported the problems

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40039
Build 36928: arc lint + arc unit

Event Timeline

• karels created this revision.Jun 20 2021, 6:00 PM
Herald added subscribers: emaste, andrew. · View Herald TranscriptJun 20 2021, 6:00 PM
• karels requested review of this revision.Jun 20 2021, 6:00 PM
Harbormaster completed remote builds in B40003: Diff 91142.Jun 20 2021, 6:00 PM
emaste added inline comments.Jun 21 2021, 3:56 PM
sys/arm64/broadcom/genet/if_genet.c
107

Maybe something like "maximum number of mbufs to pass per call to if_input" or something like that?

"send" implied the TX direction on my first read

• karels updated this revision to Diff 91203.Jun 22 2021, 12:05 AM

Fix text according to Ed's suggestion.

Harbormaster completed remote builds in B40039: Diff 91203.Jun 22 2021, 12:05 AM
• karels marked an inline comment as done.Jun 22 2021, 12:07 AM
• karels added inline comments.
sys/arm64/broadcom/genet/if_genet.c
107

Good suggestion, thanks.

emaste added a comment.Jun 22 2021, 1:42 AM

LGTM

• karels marked an inline comment as done.Jun 22 2021, 10:26 PM

Any other comments? Anyone able to approve?

emaste accepted this revision.Jun 22 2021, 11:05 PM
This revision is now accepted and ready to land.Jun 22 2021, 11:05 PM
Closed by commit rG184291b0a56a: genet: pullup minimum header amount for IPv4 (authored by • karels). · Explain WhyJun 26 2021, 4:07 PM
This revision was automatically updated to reflect the committed changes.
• karels added a commit: rG184291b0a56a: genet: pullup minimum header amount for IPv4.
• karels added a commit: rG2ecf3f2c5774: genet: pullup minimum header amount for IPv4.Jul 5 2021, 2:42 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
broadcom/
genet/
53 lines

Diff 91203

View Options

sys/arm64/broadcom/genet/if_genet.c

Loading...