Page MenuHomeFreeBSD

pf: Fix more ioctl memory leaks
ClosedPublic

Authored by kp on Jun 1 2021, 2:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 16, 3:02 AM
Unknown Object (File)
Sat, May 16, 3:02 AM
Unknown Object (File)
Sat, May 16, 3:02 AM
Unknown Object (File)
Sat, May 16, 3:01 AM
Unknown Object (File)
Fri, May 15, 5:39 AM
Unknown Object (File)
Fri, May 15, 5:38 AM
Unknown Object (File)
Thu, May 14, 9:18 PM
Unknown Object (File)
Sat, May 2, 10:52 AM

Details

Summary

We must also remember to free nvlists added to a parent nvlist with
nvlist_append_nvlist_array().

More importantly, when nvlist_pack() allocates memory for us it does so
in the M_NVLIST zone, so we must free it with free(.., M_NVLIST). Using
free(.., M_TEMP) as we did silently failed to free the memory.

MFC after: 3 days
Repored by: kib@
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable