Page MenuHomeFreeBSD

pf: Fix more ioctl memory leaks
ClosedPublic

Authored by kp on Jun 1 2021, 2:20 PM.
Tags
None
Referenced Files
F170791799: D30595.id90258.diff
Sun, Sep 6, 3:58 PM
F170720727: D30595.id.diff
Sun, Sep 6, 5:19 AM
F170646117: D30595.id.diff
Sat, Sep 5, 7:17 PM
Unknown Object (File)
Sat, Sep 5, 2:44 PM
Unknown Object (File)
Sat, Sep 5, 12:11 PM
Unknown Object (File)
Sat, Sep 5, 10:41 AM
Unknown Object (File)
Sat, Sep 5, 7:51 AM
Unknown Object (File)
Sat, Sep 5, 12:55 AM

Details

Summary

We must also remember to free nvlists added to a parent nvlist with
nvlist_append_nvlist_array().

More importantly, when nvlist_pack() allocates memory for us it does so
in the M_NVLIST zone, so we must free it with free(.., M_NVLIST). Using
free(.., M_TEMP) as we did silently failed to free the memory.

MFC after: 3 days
Repored by: kib@
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable