Page MenuHomeFreeBSD

vinvalbuf: do not panic if we were unable to flush dirty buffers
ClosedPublic

Authored by kib on May 30 2021, 5:13 PM.

Details

Summary

Return EBUSY instead and let caller to handle the issue.

For vgone()/vnode reclamation, caller first does vinvalbuf(V_SAVE), which return EBUSY in case dirty buffers where not flushed. Then caller calls vinvalbuf(0) due to non-zero return, which gets rid of all dirty buffers without dependencies.

PR: 238565

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.May 30 2021, 5:13 PM
kib created this revision.

Works for me. You should also reenable the test in tests/sys/fs/fusefs/write.cc.

This revision is now accepted and ready to land.May 30 2021, 6:35 PM

You should also reenable the test in tests/sys/fs/fusefs/write.cc.

Please do it yourself after my change.