Page MenuHomeFreeBSD
Differential D30555

vinvalbuf: do not panic if we were unable to flush dirty buffers
ClosedPublic
Actions

Authored by kib on May 30 2021, 5:13 PM.
Tags
None
Referenced Files
F159102325: D30555.diff
Wed, Jun 10, 3:48 AM
Unknown Object (File)
Tue, May 19, 5:46 AM
Unknown Object (File)
Tue, May 19, 5:46 AM
Unknown Object (File)
Mon, May 18, 2:32 PM
Unknown Object (File)
Mon, May 18, 2:32 PM
Unknown Object (File)
Mon, May 18, 2:32 PM
Unknown Object (File)
Mon, May 18, 2:32 PM
Unknown Object (File)
Sun, May 17, 9:49 PM
View All Files
Subscribers
imp

Details

Reviewers
mckusick
asomers
Commits
rG7dcb5db451b6: vinvalbuf: do not panic if we were unable to flush dirty buffers
rG27006229f7a4: vinvalbuf: do not panic if we were unable to flush dirty buffers
Summary

Return EBUSY instead and let caller to handle the issue.

For vgone()/vnode reclamation, caller first does vinvalbuf(V_SAVE), which return EBUSY in case dirty buffers where not flushed. Then caller calls vinvalbuf(0) due to non-zero return, which gets rid of all dirty buffers without dependencies.

PR: 238565

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.May 30 2021, 5:13 PM
kib created this revision.
asomers accepted this revision.May 30 2021, 6:35 PM

Works for me. You should also reenable the test in tests/sys/fs/fusefs/write.cc.

This revision is now accepted and ready to land.May 30 2021, 6:35 PM
kib added a comment.May 30 2021, 7:37 PM
In D30555#686195, @asomers wrote:

You should also reenable the test in tests/sys/fs/fusefs/write.cc.

Please do it yourself after my change.

mckusick accepted this revision.May 30 2021, 9:57 PM

This looks good to me.

Closed by commit rG27006229f7a4: vinvalbuf: do not panic if we were unable to flush dirty buffers (authored by kib). · Explain WhyMay 30 2021, 10:21 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG27006229f7a4: vinvalbuf: do not panic if we were unable to flush dirty buffers.
asomers added a commit: rG7dcb5db451b6: vinvalbuf: do not panic if we were unable to flush dirty buffers.Oct 7 2021, 7:42 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 7 2021, 7:42 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
10 lines

Diff 90144

View Options

sys/kern/vfs_subr.c

Loading...