libpfctl: fix memory leak
ClosedPublic
Actions

Authored by kp on May 27 2021, 9:48 AM.

Details

Reviewers

Group Reviewers

Commits

rGa75154a11586: libpfctl: fix memory leak
rG38da14043dcc: libpfctl: fix memory leak
rG6dbb729d35d5: libpfctl: fix memory leak

Summary

When we create an nvlist and insert it into another nvlist we must
remember to destroy it. The nvlist_add_nvlist() function makes a copy,
just like nvlist_add_string() makes a copy of the string.

MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 27 2021, 9:48 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 27 2021, 9:48 AM

kp requested review of this revision.May 27 2021, 9:48 AM

Harbormaster completed remote builds in B39493: Diff 89956.May 27 2021, 9:48 AM

kp added a child revision: D30493: libpfctl: Improve error handling in pfctl_get_states().May 27 2021, 9:48 AM

This looks like a deficiency in the API design, but I don't object to this change.

This revision is now accepted and ready to land.May 28 2021, 7:14 PM

In D30492#685685, @scottl wrote:

This looks like a deficiency in the API design, but I don't object to this change.

You mean the nvlist API? Not really. This one is on me.
The API is consistent in copying data that's added to an nvlist with nvlist_add_*(). It does it with strings, and it also does it with nvlists. It does make sense, but I'd not thought of that when I originally wrote this code.

Closed by commit rG6dbb729d35d5: libpfctl: fix memory leak (authored by kp). · Explain WhyMay 31 2021, 1:39 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG6dbb729d35d5: libpfctl: fix memory leak.

kp added a commit: rG38da14043dcc: libpfctl: fix memory leak.Jun 3 2021, 1:41 PM

kp added a commit: rGa75154a11586: libpfctl: fix memory leak.