Differential D30493

libpfctl: Improve error handling in pfctl_get_states()
ClosedPublic
Actions

Authored by kp on May 27 2021, 9:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 13, 10:06 PM

	Unknown Object (File)
	Wed, May 13, 10:06 PM

	Unknown Object (File)
	Wed, May 13, 9:55 PM

	Unknown Object (File)
	Sat, May 9, 6:14 AM

	Unknown Object (File)
	Sun, May 3, 6:50 PM

	Unknown Object (File)
	Wed, Apr 29, 1:11 PM

	Unknown Object (File)
	Tue, Apr 28, 8:55 PM

	Unknown Object (File)
	Mon, Apr 27, 11:28 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG2e7cd5ec7e62: libpfctl: Improve error handling in pfctl_get_states()
rGdec754f05d9c: libpfctl: Improve error handling in pfctl_get_states()
rG27c77f42ae74: libpfctl: Improve error handling in pfctl_get_states()

Summary

Ensure that we always free nvlists and other allocated memory.

MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 27 2021, 9:48 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 27 2021, 9:48 AM

kp requested review of this revision.May 27 2021, 9:48 AM

Harbormaster completed remote builds in B39494: Diff 89957.May 27 2021, 9:48 AM

kp added a parent revision: D30492: libpfctl: fix memory leak.May 27 2021, 9:48 AM

scottl accepted this revision.May 28 2021, 7:18 PM

This revision is now accepted and ready to land.May 28 2021, 7:18 PM

Closed by commit rG27c77f42ae74: libpfctl: Improve error handling in pfctl_get_states() (authored by kp). · Explain WhyMay 31 2021, 1:39 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG27c77f42ae74: libpfctl: Improve error handling in pfctl_get_states().

kp added a commit: rGdec754f05d9c: libpfctl: Improve error handling in pfctl_get_states().Jun 3 2021, 1:41 PM

kp added a commit: rG2e7cd5ec7e62: libpfctl: Improve error handling in pfctl_get_states().

Revision Contents
Changeset List

Path

Size

lib/

libpfctl/

28 lines

Diff 90168

lib/libpfctl/libpfctl.c

Loading...