Page MenuHomeFreeBSD
Differential D30482

Retire unnecessary __packed attribute from some struct's definition.
ClosedPublic
Actions

Authored by dchagin on May 26 2021, 7:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 7 2024, 6:37 PM
Unknown Object (File)
Feb 3 2024, 8:10 PM
Unknown Object (File)
Jan 14 2024, 5:04 AM
Unknown Object (File)
Jan 13 2024, 7:51 AM
Unknown Object (File)
Dec 23 2023, 12:20 AM
Unknown Object (File)
Dec 22 2023, 5:37 PM
Unknown Object (File)
Nov 28 2023, 7:44 AM
Unknown Object (File)
Nov 27 2023, 5:07 PM
View All 30 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
Group Reviewers
Linux Emulation
Commits
rG587982d0d902: linux(4); Retire unnecessary __packed attribute from some struct's
rG19593f775c23: linux(4); Retire unnecessary __packed attribute from some struct's
Test Plan

Glibc nptl tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.May 26 2021, 7:24 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 26 2021, 7:24 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
dchagin requested review of this revision.May 26 2021, 7:24 PM
Harbormaster completed remote builds in B39478: Diff 89929.May 26 2021, 7:24 PM
dchagin edited the summary of this revision. (Show Details)May 26 2021, 7:26 PM
dchagin edited the test plan for this revision. (Show Details)
dchagin added a reviewer: Linux Emulation.
emaste added a comment.May 26 2021, 7:39 PM

Seems reasonable, out of curiosity what prompted taking this on? (I.e., did you discover an issue with the current version?)

dchagin added a comment.May 26 2021, 9:40 PM
In D30482#684754, @emaste wrote:

Seems reasonable, out of curiosity what prompted taking this on? (I.e., did you discover an issue with the current version?)

nothing serious, I read the code from pitwuu and see that the structure definition with wrong _packed are copied

This revision was not accepted when it landed; it landed in state Needs Review.May 31 2021, 6:57 PM
Closed by commit rG19593f775c23: linux(4); Retire unnecessary __packed attribute from some struct's (authored by dchagin). · Explain Why
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG19593f775c23: linux(4); Retire unnecessary __packed attribute from some struct's.
dchagin added a commit: rG587982d0d902: linux(4); Retire unnecessary __packed attribute from some struct's.Jun 17 2022, 7:24 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
5 lines
linux32/
53 lines
arm64/
linux/
5 lines
i386/
linux/
2 lines

Diff 90199

View Options

sys/amd64/linux/linux.h

Loading...
View Options

sys/amd64/linux32/linux.h

Loading...
View Options

sys/arm64/linux/linux.h

Loading...
View Options

sys/i386/linux/linux.h

Loading...