Differential D30467

LACP: Do not wait response for marker messages not sent
ClosedPublic
Actions

Authored by arnaud.ysmal_stormshield.eu on May 26 2021, 1:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 7, 6:19 AM

	Unknown Object (File)
	Mon, Oct 6, 11:36 AM

	Unknown Object (File)
	Mon, Sep 29, 10:56 AM

	Unknown Object (File)
	Sun, Sep 21, 4:29 PM

	Unknown Object (File)
	Sep 17 2025, 10:35 AM

	Unknown Object (File)
	Sep 9 2025, 9:05 PM

	Unknown Object (File)
	Sep 5 2025, 5:38 PM

	Unknown Object (File)
	Sep 4 2025, 10:15 AM

Subscribers

stephane.rochoy_stormshield.eu

Details

Reviewers

Commits

rG1315446ba0cd: LACP: Do not wait response for marker messages not sent
rG0b92a7fe47a5: LACP: Do not wait response for marker messages not sent

Summary

The error returned when a marker message can not be emitted on a port is not handled.

This cause the lacp to block all emissions until the timeout of 3 seconds is reached.

To fix this issue, I just clear the LACP_PORT_MARK flag when the packet could not be emitted.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arnaud.ysmal_stormshield.eu created this revision.May 26 2021, 1:08 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptMay 26 2021, 1:08 PM

arnaud.ysmal_stormshield.eu requested review of this revision.May 26 2021, 1:08 PM

I also added a sysctl to modify the value of this timeout in the enclosed patch.

transit_delay_sysctl.patch1 KBDownload

stephane.rochoy_stormshield.eu added a subscriber: stephane.rochoy_stormshield.eu.Jun 30 2021, 9:50 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 23 2021, 8:58 AM

Closed by commit rG0b92a7fe47a5: LACP: Do not wait response for marker messages not sent (authored by arnaud.ysmal_stormshield.eu, committed by wma). · Explain Why

This revision was automatically updated to reflect the committed changes.

wma added a commit: rG0b92a7fe47a5: LACP: Do not wait response for marker messages not sent.

wma added a commit: rG1315446ba0cd: LACP: Do not wait response for marker messages not sent.Jun 7 2022, 3:58 AM

Herald added subscribers: glebius, imp. · View Herald TranscriptJun 7 2022, 3:58 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

ieee8023ad_lacp.c

3 lines

Diff 95554

sys/net/ieee8023ad_lacp.c

Loading...