Page MenuHomeFreeBSD

www/pydio-cells: Fix build and overhaul
ClosedPublic

Authored by skozlov on May 17 2021, 11:00 PM.

Details

Summary

(requires D30322)

www/pydio-cells: Fix build and overhaul

Pydio cells uses a custom version of packr to embed the static
resources into the `cells` binary. Previously, the embedding process
was not peformed, resulting in a non-functional binary. When trying
to use the app, user will just get "404 Not Found" error instead of
a web page.

To fix this - before the build `gmake generate` has to be performed
in the WRKSRC, and a special custom version of packr v1
(devel/pydio-packr) has to be used.

Other changes:
- DOCS option was removed, as the README.md file didn't really provide
  any useful information for the port's users
- Generation of bash and zsh completion files was added
- App version is now provided during the build process (previously 0.1.0
  would be indicated instead of the real version)
- Indicate failure to build on i386
- Create separate user/group for running the daemon, as recommended by
  the administrator's manual
- Add rc script
- Add pkg-message with configuration instructions
- Add more patches fixing bugs and adapting the code for FreeBSD

No UPDATING is required, as the port was not functional previously

Reviewed_by: ???
MFH: No (port isn't in any of the quarterly branches yet)
Differential_Revision: D30323
Test Plan
  • portlint -AC OK
  • poudriere testport OK (attached)
  • rclint OK
  • Used resulting package to configure and smoke test the app

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

skozlov edited the test plan for this revision. (Show Details)

Added RC script, couple more patches, and a separate user/group
New poudriere log:

skozlov edited the test plan for this revision. (Show Details)
koobs requested changes to this revision.May 26 2021, 12:44 AM
koobs added a subscriber: koobs.
koobs added inline comments.
www/pydio-cells/Makefile
14

If its supposed to build, this might be better as BROKEN

Otherwise, message is probably better as "Not supported"

29–30
  • Group USES/USE_* together
  • Does USE_RC_SUBR support yes which defaults to PORTNAME ?
31
  • Use existing shared options names and descriptions when available
grep -Ri completions /usr/ports/Mk/bsd.options.desc.mk
/usr/ports/Mk/bsd.options.desc.mk:BASH_DESC?=           Install programmable completions for Bash
/usr/ports/Mk/bsd.options.desc.mk:FISH_DESC?=           Install programmable completions for Fish
/usr/ports/Mk/bsd.options.desc.mk:ZSH_DESC?=            Install programmable completions for zsh
www/pydio-cells/files/patch-cmd_start.go
1

Add comment headers for patches for our future selves & upstreaming

www/pydio-cells/files/patch-common_config_dirs.go
1

Add comment headers for patches for our future selves & upstreaming

This revision now requires changes to proceed.May 26 2021, 12:44 AM
  • For changes that are not feature additions, MFH. For all differentials, so its obvious and explicit, add to commit log message (summary)
MFH: <branch>|No (<reason>)
  • BROKEN due to lack of support, not build failure
  • Group USE* together
  • Use standard optons for BASH and ZSH
  • Add comments to patches

Tests:

  • portlint -AC still OK
  • poudriere testport still OK
skozlov added inline comments.
www/pydio-cells/Makefile
29–30
  • Does USE_RC_SUBR support yes which defaults to PORTNAME ?

Unfortunately, it doesn't:

$ grep -C3 'USE_RC_SUBR' bsd.port.mk
--
.endif

.if defined(USE_RC_SUBR)
SUB_FILES+=     ${USE_RC_SUBR}
.endif

--

.if !target(install-rc-script)
.if defined(USE_RC_SUBR)
install-rc-script:
        @${ECHO_MSG} "===> Staging rc.d startup script(s)"
        @for i in ${USE_RC_SUBR}; do \
                _prefix=${PREFIX}; \
                [ "${PREFIX}" = "/usr" ] && _prefix="" ; \
29–30
  • Group USES/USE_* together
  • Does USE_RC_SUBR support yes which defaults to PORTNAME ?
skozlov added inline comments.
www/pydio-cells/Makefile
29–30

Please disregard this comment

koobs requested changes to this revision.May 28 2021, 1:28 AM
koobs added inline comments.
UIDs
238

Sorry I missed this. Does it require /bin/sh and a login? (ie; does it break if its /usr/sbin/nologin)

This revision now requires changes to proceed.May 28 2021, 1:28 AM
skozlov added inline comments.
UIDs
238

This is done to enable service cells cli ... commands (check out cells.in:57). Even if not done through the rc script - the user will still require a shell (or sudo) to login as pydio to perform configure operation (check out pkg-message).

P.S. No worries, thanks for looking into this, again :)

This revision is now accepted and ready to land.May 30 2021, 2:06 AM
This revision was automatically updated to reflect the committed changes.