[NEW] devel/pydio-packr: Pydio port of packr v1 This is a fork of gobuffalo's packr v1 customized by pydio team. Its sole purpose is to be used in building the www/pydio-cells port. WWW: https://github.com/pydio/packr Reviewed_by: koobs Differential_Revision: D30322
Details
- Reviewers
koobs - Commits
- R11:b9881243bfc4: [NEW] devel/pydio-packr: Pydio port of packr v1
- portlint -AC OK (with # $FreeBSD$ added at the beginning of Makefile)
- poudriere testport OK
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Can/should this port just be included (bundled as a dep) for www/pydio-cells?
devel/pydio-packr/Makefile | ||
---|---|---|
4–5 | I'm not sure this is the best versioning definition for Go applications. I may be wrong. See: https://docs.freebsd.org/en/books/porters-handbook/special/#using-go and |
I tried to do that, but it seems much harder to do than a separate port, reasons are:
- packr uses go:modules while cells use simple go, which changes the build process substantially
- packr has to be run through Makefile before the build phase, so this means that I need packr built before build phase of the port - a chicken and egg problem
- USES= go takes care of pretty much all the machinery for me if used in a separate port, but not in case I need to pre-build a tool to build another one
devel/pydio-packr/Makefile | ||
---|---|---|
4–5 | I think it's the only way it can be done with USES= go:modules. |
Understood. Just be careful with PORTVERSION/DISTVERSION going backward for future tagged versions. See:
https://docs.freebsd.org/en/books/porters-handbook/makefiles
Example 14. Using USE_GITHUB to Access a Commit Between Two Versions
Sure, this artificial revision is made in such a way that the risk is minimized, it includes both the version and the exact timestamp for that.
https://docs.freebsd.org/en/books/porters-handbook/makefiles
Example 14. Using USE_GITHUB to Access a Commit Between Two Versions
I tried using USE_GITHUB but it's not compatible with GO_MODULE, you can only use those artificial versions to fetch a commit snapshot through the go proxy website.
Anyway, thanks again for the review, really appreciate that, @koobs! :)