Page MenuHomeFreeBSD

service/ipfw: Silence warning on restart
ClosedPublic

Authored by donner on May 2 2021, 8:51 PM.

Details

Summary

Once the ipfw0 interface has been created, ifconfig(8) create will
throw a warning: ifconfig: create: bad value' when trying to create it
again.

PR: 241013
Submitted by: Jose Luis Duran
MFC after: 2 weeks

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

donner requested review of this revision.May 2 2021, 8:51 PM

The idea was to make it more in line with pflog's behavior, and of course to silence the warning. The patch is good as is for me, however.

Thank you for reviewing this.

donner added a subscriber: kp.

Add @kp for the pflog reference.

kp added inline comments.
libexec/rc/rc.d/ipfw
81

I think I wouldn't include this warning. After all, the system state is what we wanted it to be: we want ipfw0 to exist and it does.

This revision is now accepted and ready to land.May 3 2021, 9:40 AM
This revision was automatically updated to reflect the committed changes.
donner marked an inline comment as done.